Take info, warn, and error log levels

Author: lionel-

apps/lsp/src/config.ts

@@ -83,7 +83,7 @@ function defaultSettings(): Settings {
       colorTheme: 'Dark+'
     },
     quarto: {
-      logLevel: LogLevel.Trace,
+      logLevel: LogLevel.Info,
       path: "",
       mathjax: {
         scale: 1,

apps/lsp/src/logging.ts

@@ -83,16 +83,18 @@ export class LogFunctionLogger extends Disposable implements ILogger {
     switch (logLevel) {
       case 'trace': return LogLevel.Trace;
       case 'debug': return LogLevel.Debug;
-      case 'off':
+      case 'info': return LogLevel.Info;
+      case 'warn': return LogLevel.Warn;
+      case 'error': return LogLevel.Error;
       default:
-        return LogLevel.Off;
+        return LogLevel.Warn;
     }
   }
 
   get level(): LogLevel { return this._logLevel; }
 
   public log(level: LogLevel, message: string, data?: unknown): void {
-    if (this.level < level) {
+    if (level < this.level) {
       return;
     }
 
@@ -112,9 +114,11 @@ export class LogFunctionLogger extends Disposable implements ILogger {
 
   private toLevelLabel(level: LogLevel): string {
     switch (level) {
-      case LogLevel.Off: return 'off';
-      case LogLevel.Debug: return 'debug';
       case LogLevel.Trace: return 'trace';
+      case LogLevel.Debug: return 'debug';
+      case LogLevel.Info: return 'info';
+      case LogLevel.Warn: return 'warn';
+      case LogLevel.Error: return 'error';
     }
   }
 

apps/lsp/src/service/logging.ts

@@ -18,14 +18,20 @@
  * The level of verbosity that the language service logs at.
  */
 export enum LogLevel {
-  /** Disable logging */
-  Off,
+  /** Log extremely verbose info about language server operation, such as calls into the file system */
+  Trace,
 
   /** Log verbose info about language server operation, such as when references are re-computed for a md file. */
   Debug,
 
-  /** Log extremely verbose info about language server operation, such as calls into the file system */
-  Trace,
+  /** Informational messages that highlight the progress of the application at coarse-grained level. */
+  Info,
+
+  /** Potentially harmful situations which still allow the application to continue running. */
+  Warn,
+
+  /** Error events that might still allow the application to continue running. */
+  Error,
 }
 
 /**

apps/vscode/package.json

@@ -1314,7 +1314,9 @@
           "enum": [
             "trace",
             "debug",
-            "off"
+            "info",
+            "warn",
+            "error"
           ],
           "markdownDescription": "Log level for the Quarto language server."
         }