add support for tab for accepting completions

Author: vezwork

packages/editor-codemirror/src/behaviors/indent.ts

@@ -13,18 +13,29 @@
  *
  */
 
-import { indentWithTab } from "@codemirror/commands";
+import { indentLess, indentMore } from "@codemirror/commands";
 
 import { indentOnInput } from "@codemirror/language";
 import { keymap } from "@codemirror/view";
 
 import { Behavior } from ".";
+import { acceptCompletion, completionStatus } from "@codemirror/autocomplete";
 
-export function indentBehavior() : Behavior {
+export function tabBehavior(): Behavior {
   return {
     extensions: [
       indentOnInput(),
-      keymap.of([indentWithTab])
+      keymap.of([
+        {
+          key: 'Tab',
+          preventDefault: true,
+          shift: indentLess,
+          run: e => {
+            if (!completionStatus(e.state)) return indentMore(e);
+            return acceptCompletion(e);
+          },
+        },
+      ])
     ]
-  }
+  };
 }

packages/editor-codemirror/src/behaviors/index.ts

@@ -27,7 +27,7 @@ import { CodeViewOptions, ExtensionContext } from "editor";
 import { langModeBehavior } from './langmode';
 import { keyboardBehavior } from './keyboard';
 import { findBehavior } from './find';
-import { indentBehavior } from './indent';
+import { tabBehavior } from './indent';
 import { trackSelectionBehavior } from './trackselection';
 import { themeBehavior } from './theme';
 import { prefsBehavior } from './prefs';
@@ -63,7 +63,7 @@ export function createBehaviors(context: BehaviorContext): Behavior[] {
     langModeBehavior(context),
     completionBehavior(context),
     findBehavior(context),
-    indentBehavior(),
+    tabBehavior(),
     themeBehavior(context),
     prefsBehavior(context),
     trackSelectionBehavior(context),