Fix math formula color detection with autoDetectColorScheme

- Add notification system to send actual theme kind from VS Code to LSP
- Track active color theme kind in LSP ConfigurationManager
- Send theme notifications on startup and when theme changes
- Use actual theme kind instead of parsing theme name

Co-authored-by: kv9898 <[email protected]>

Author: Copilot

apps/lsp/src/config.ts

@@ -136,6 +136,7 @@ export class ConfigurationManager extends Disposable {
 
   private _settings: Settings;
   private _logger: ILogger;
+  private _activeColorThemeKind: "light" | "dark" = "dark";
 
   constructor(
     private readonly connection_: Connection,
@@ -177,6 +178,13 @@ export class ConfigurationManager extends Disposable {
         }
       }
     };
+    
+    // Fallback: try to detect theme from name if we haven't received an explicit notification yet
+    // This is a best-effort approach for compatibility, but won't work with autoDetectColorScheme
+    if (settings.workbench.colorTheme.includes("Light")) {
+      this._activeColorThemeKind = "light";
+    }
+    
     this._onDidChangeConfiguration.fire(this._settings);
   }
 
@@ -202,6 +210,15 @@ export class ConfigurationManager extends Disposable {
   public getSettings(): Settings {
     return this._settings;
   }
+
+  public setActiveColorThemeKind(kind: "light" | "dark") {
+    this._activeColorThemeKind = kind;
+    this._onDidChangeConfiguration.fire(this._settings);
+  }
+
+  public getActiveColorThemeKind(): "light" | "dark" {
+    return this._activeColorThemeKind;
+  }
 }
 
 export function lsConfiguration(configManager: ConfigurationManager): LsConfiguration {
@@ -226,8 +243,7 @@ export function lsConfiguration(configManager: ConfigurationManager): LsConfigur
       }
     },
     get colorTheme(): "light" | "dark" {
-      const settings = configManager.getSettings();
-      return settings.workbench.colorTheme.includes("Light") ? "light" : "dark";
+      return configManager.getActiveColorThemeKind();
     },
     get mathjaxScale(): number {
       return configManager.getSettings().quarto.mathjax.scale;

apps/lsp/src/index.ts

@@ -224,6 +224,12 @@ connection.onInitialized(async () => {
     logger.setConfigurationManager(configManager);
   }
 
+  // listen for color theme changes from the client
+  connection.onNotification("quarto/didChangeActiveColorTheme", (params: { kind: "light" | "dark" }) => {
+    logger.logNotification('didChangeActiveColorTheme');
+    configManager.setActiveColorThemeKind(params.kind);
+  });
+
   // initialize connection to quarto
   const workspaceFolders = await connection.workspace.getWorkspaceFolders();
   const workspaceDir = workspaceFolders?.length

apps/vscode-editor/vite.config.ts.timestamp-1762271143169.mjs

@@ -0,0 +1,43 @@
+// vite.config.ts
+import path from "path";
+import { defineConfig, normalizePath } from "file:///home/runner/work/quarto/quarto/node_modules/vite/dist/node/index.js";
+import { viteStaticCopy } from "file:///home/runner/work/quarto/quarto/node_modules/vite-plugin-static-copy/dist/index.js";
+var __vite_injected_original_dirname = "/home/runner/work/quarto/quarto/apps/vscode-editor";
+var vite_config_default = defineConfig((env) => {
+  const dev = env.mode === "development";
+  return {
+    define: {
+      "process.env.DEBUG": '""',
+      "process.env.NODE_ENV": '"production"',
+      "process.env.TERM": '""',
+      "process.platform": '""'
+    },
+    plugins: [
+      viteStaticCopy({
+        targets: [
+          {
+            src: normalizePath(path.resolve(__vite_injected_original_dirname, "./dist/*")),
+            dest: normalizePath(path.resolve(__vite_injected_original_dirname, "../vscode/assets/www/editor"))
+          }
+        ]
+      })
+    ],
+    build: {
+      watch: dev ? {} : null,
+      lib: {
+        entry: "src/index.tsx",
+        formats: ["umd"],
+        name: "QuartoVisualEditor",
+        fileName: () => "index.js"
+      },
+      rollupOptions: {
+        external: ["vscode-webview"]
+      },
+      sourcemap: dev ? "inline" : false
+    }
+  };
+});
+export {
+  vite_config_default as default
+};
+//# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsidml0ZS5jb25maWcudHMiXSwKICAic291cmNlc0NvbnRlbnQiOiBbImNvbnN0IF9fdml0ZV9pbmplY3RlZF9vcmlnaW5hbF9kaXJuYW1lID0gXCIvaG9tZS9ydW5uZXIvd29yay9xdWFydG8vcXVhcnRvL2FwcHMvdnNjb2RlLWVkaXRvclwiO2NvbnN0IF9fdml0ZV9pbmplY3RlZF9vcmlnaW5hbF9maWxlbmFtZSA9IFwiL2hvbWUvcnVubmVyL3dvcmsvcXVhcnRvL3F1YXJ0by9hcHBzL3ZzY29kZS1lZGl0b3Ivdml0ZS5jb25maWcudHNcIjtjb25zdCBfX3ZpdGVfaW5qZWN0ZWRfb3JpZ2luYWxfaW1wb3J0X21ldGFfdXJsID0gXCJmaWxlOi8vL2hvbWUvcnVubmVyL3dvcmsvcXVhcnRvL3F1YXJ0by9hcHBzL3ZzY29kZS1lZGl0b3Ivdml0ZS5jb25maWcudHNcIjtpbXBvcnQgcGF0aCBmcm9tICdwYXRoJ1xuaW1wb3J0IHsgZGVmaW5lQ29uZmlnLCBub3JtYWxpemVQYXRoIH0gZnJvbSAndml0ZSdcbmltcG9ydCB7IHZpdGVTdGF0aWNDb3B5IH0gZnJvbSAndml0ZS1wbHVnaW4tc3RhdGljLWNvcHknXG5cblxuZXhwb3J0IGRlZmF1bHQgZGVmaW5lQ29uZmlnKGVudiA9PiB7XG4gIFxuICBjb25zdCBkZXYgPSBlbnYubW9kZSA9PT0gXCJkZXZlbG9wbWVudFwiO1xuXG4gIHJldHVybiB7XG4gICAgZGVmaW5lOiB7XG4gICAgICAncHJvY2Vzcy5lbnYuREVCVUcnOiAnXCJcIicsXG4gICAgICAncHJvY2Vzcy5lbnYuTk9ERV9FTlYnOiAnXCJwcm9kdWN0aW9uXCInLFxuICAgICAgJ3Byb2Nlc3MuZW52LlRFUk0nOiAnXCJcIicsXG4gICAgICAncHJvY2Vzcy5wbGF0Zm9ybSc6ICdcIlwiJ1xuICAgIH0sXG4gICAgcGx1Z2luczogW1xuICAgICAgdml0ZVN0YXRpY0NvcHkoe1xuICAgICAgICB0YXJnZXRzOiBbXG4gICAgICAgICAge1xuICAgICAgICAgICAgc3JjOiBub3JtYWxpemVQYXRoKHBhdGgucmVzb2x2ZShfX2Rpcm5hbWUsICcuL2Rpc3QvKicpKSxcbiAgICAgICAgICAgIGRlc3Q6IG5vcm1hbGl6ZVBhdGgocGF0aC5yZXNvbHZlKF9fZGlybmFtZSwgJy4uL3ZzY29kZS9hc3NldHMvd3d3L2VkaXRvcicpKVxuICAgICAgICAgIH1cbiAgICAgICAgXVxuICAgICAgfSlcbiAgICBdLFxuICAgIGJ1aWxkOiB7XG4gICAgICB3YXRjaDogZGV2ID8ge30gOiBudWxsLFxuICAgICAgbGliOiB7XG4gICAgICAgIGVudHJ5OiAnc3JjL2luZGV4LnRzeCcsXG4gICAgICAgIGZvcm1hdHM6IFsndW1kJ10sXG4gICAgICAgIG5hbWU6IFwiUXVhcnRvVmlzdWFsRWRpdG9yXCIsXG4gICAgICAgIGZpbGVOYW1lOiAoKSA9PiAnaW5kZXguanMnIFxuICAgICAgfSxcbiAgICAgIHJvbGx1cE9wdGlvbnM6IHtcbiAgICAgICAgZXh0ZXJuYWw6IFsndnNjb2RlLXdlYnZpZXcnXSxcbiAgICAgIH0sXG4gICAgICBzb3VyY2VtYXA6IGRldiA/ICdpbmxpbmUnIDogZmFsc2VcbiAgICB9XG4gIH07XG4gXG59KTtcbiJdLAogICJtYXBwaW5ncyI6ICI7QUFBd1UsT0FBTyxVQUFVO0FBQ3pWLFNBQVMsY0FBYyxxQkFBcUI7QUFDNUMsU0FBUyxzQkFBc0I7QUFGL0IsSUFBTSxtQ0FBbUM7QUFLekMsSUFBTyxzQkFBUSxhQUFhLFNBQU87QUFFakMsUUFBTSxNQUFNLElBQUksU0FBUztBQUV6QixTQUFPO0FBQUEsSUFDTCxRQUFRO0FBQUEsTUFDTixxQkFBcUI7QUFBQSxNQUNyQix3QkFBd0I7QUFBQSxNQUN4QixvQkFBb0I7QUFBQSxNQUNwQixvQkFBb0I7QUFBQSxJQUN0QjtBQUFBLElBQ0EsU0FBUztBQUFBLE1BQ1AsZUFBZTtBQUFBLFFBQ2IsU0FBUztBQUFBLFVBQ1A7QUFBQSxZQUNFLEtBQUssY0FBYyxLQUFLLFFBQVEsa0NBQVcsVUFBVSxDQUFDO0FBQUEsWUFDdEQsTUFBTSxjQUFjLEtBQUssUUFBUSxrQ0FBVyw2QkFBNkIsQ0FBQztBQUFBLFVBQzVFO0FBQUEsUUFDRjtBQUFBLE1BQ0YsQ0FBQztBQUFBLElBQ0g7QUFBQSxJQUNBLE9BQU87QUFBQSxNQUNMLE9BQU8sTUFBTSxDQUFDLElBQUk7QUFBQSxNQUNsQixLQUFLO0FBQUEsUUFDSCxPQUFPO0FBQUEsUUFDUCxTQUFTLENBQUMsS0FBSztBQUFBLFFBQ2YsTUFBTTtBQUFBLFFBQ04sVUFBVSxNQUFNO0FBQUEsTUFDbEI7QUFBQSxNQUNBLGVBQWU7QUFBQSxRQUNiLFVBQVUsQ0FBQyxnQkFBZ0I7QUFBQSxNQUM3QjtBQUFBLE1BQ0EsV0FBVyxNQUFNLFdBQVc7QUFBQSxJQUM5QjtBQUFBLEVBQ0Y7QUFFRixDQUFDOyIsCiAgIm5hbWVzIjogW10KfQo=

apps/vscode/src/lsp/client.ts

@@ -24,7 +24,9 @@ import {
   Definition,
   LogOutputChannel,
   Uri,
-  Diagnostic
+  Diagnostic,
+  window,
+  ColorThemeKind
 } from "vscode";
 import {
   LanguageClient,
@@ -151,12 +153,29 @@ export async function activateLsp(
     clientOptions
   );
 
+  // Helper to send current theme to LSP server
+  const sendThemeNotification = () => {
+    if (client) {
+      const kind = window.activeColorTheme.kind === ColorThemeKind.Light ? "light" : "dark";
+      client.sendNotification("quarto/didChangeActiveColorTheme", { kind });
+    }
+  };
+
+  // Listen for theme changes and notify the server
+  context.subscriptions.push(
+    window.onDidChangeActiveColorTheme(() => {
+      sendThemeNotification();
+    })
+  );
+
   // return once the server is running
   return new Promise<LanguageClient>((resolve, reject) => {
 
     const handler = client.onDidChangeState(e => {
       if (e.newState === State.Running) {
         handler.dispose();
+        // Send initial theme on startup
+        sendThemeNotification();
         resolve(client);
       } else if (e.newState === State.Stopped) {
         reject(new Error("Failed to start Quarto LSP Server"));