Force a user save on untitled documents, before switch to visual mode (#831)

* Force a user save on untitled documents, before switch to visual mode

* Update CHANGELOG

* Fix for opening unsaved file in VE in VSCode

* Make linter happy

---------

Co-authored-by: elliot <[email protected]>

Author: juliasilge

apps/vscode/CHANGELOG.md

@@ -3,8 +3,9 @@
 ## 1.125.0 (Unreleased)
 
 - Fixed an issue where attribute values containing '='s could be truncated in some scenarios (<https://github.com/quarto-dev/quarto/pull/814>).
-- Fixed an issue where a loading spinner for qmd previews wasn't dismissed on preview errors (<https://github.com/quarto-dev/quarto/pull/823>)
+- Fixed an issue where a loading spinner for qmd previews wasn't dismissed on preview errors (<https://github.com/quarto-dev/quarto/pull/823>).
 - Diagnostics are no longer reported for internal temporary virtual document files (<https://github.com/quarto-dev/quarto/pull/832>).
+- Fixed switching to visual mode for untitled documents in Positron (<https://github.com/quarto-dev/quarto/pull/831>).
 
 ## 1.124.0 (Release on 2025-08-20)
 

apps/vscode/src/providers/editor/toggle.ts

@@ -13,12 +13,11 @@
  *
  */
 
-import { commands, window, workspace, TextDocument, ViewColumn } from "vscode";
+import { Uri, commands, window, workspace, TextDocument, ViewColumn } from "vscode";
 import * as quarto from "quarto-core";
 import { Command } from "../../core/command";
 import { isQuartoDoc, kQuartoLanguageId } from "../../core/doc";
 import { VisualEditorProvider } from "./editor";
-import { Uri } from "vscode";
 import { hasHooks } from "../../host/hooks";
 import { toggleEditMode, toggleRenderOnSaveOverride } from "../context-keys";
 
@@ -123,20 +122,25 @@ export async function reopenEditorInVisualMode(
   if (hasHooks()) {
     // note pending switch to visual
     VisualEditorProvider.recordPendingSwitchToVisual(document);
+    // if document is untitled, force user to save first
+    if (document.isUntitled) {
+      await commands.executeCommand("workbench.action.files.save");
+    }
+    // reopen in visual mode
     commands.executeCommand('positron.reopenWith', document.uri, 'quarto.visualEditor');
   } else {
-    // save then close
+    workspace.onDidSaveTextDocument(async (doc: TextDocument) => {
+      // open in visual mode
+      VisualEditorProvider.recordPendingSwitchToVisual(doc);
+      await commands.executeCommand('workbench.action.closeActiveEditor');
+      await commands.executeCommand("vscode.openWith",
+        doc.uri,
+        VisualEditorProvider.viewType,
+        { viewColumn }
+      );
+    });
+    // save, which will trigger `onDidSaveTextDocument`
     await commands.executeCommand("workbench.action.files.save");
-    await commands.executeCommand('workbench.action.closeActiveEditor');
-    VisualEditorProvider.recordPendingSwitchToVisual(document);
-    // open in visual mode
-    await commands.executeCommand("vscode.openWith",
-      document.uri,
-      VisualEditorProvider.viewType,
-      {
-        viewColumn
-      }
-    );
   }
 }