No more config

Author: juliasilge

apps/vscode/package.json

@@ -1045,13 +1045,6 @@
           "default": true,
           "markdownDescription": "Use reticulate to execute Python cells within Knitr engine documents."
         },
-        "quarto.vdoc.hideDiagnostics": {
-          "order": 26,
-          "scope": "window",
-          "type": "boolean",
-          "default": true,
-          "markdownDescription": "Hide diagnostics (problems) reported for internal virtual document files. These are temporary files used to provide language features in code blocks."
-        },
         "quarto.mathjax.scale": {
           "order": 15,
           "scope": "window",

apps/vscode/src/lsp/client.ts

@@ -55,8 +55,8 @@ import {
   unadjustedRange,
   virtualDoc,
   withVirtualDocUri,
-  isVirtualDoc,
 } from "../vdoc/vdoc";
+import { isVirtualDoc } from "../vdoc/vdoc-tempfile";
 import { activateVirtualDocEmbeddedContent } from "../vdoc/vdoc-content";
 import { vdocCompletions } from "../vdoc/vdoc-completion";
 
@@ -102,6 +102,7 @@ export async function activateLsp(
   const config = workspace.getConfiguration("quarto");
   activateVirtualDocEmbeddedContent();
   const middleware: Middleware = {
+    handleDiagnostics: createDiagnosticFilter(),
     provideCompletionItem: embeddedCodeCompletionProvider(engine),
     provideDefinition: embeddedGoToDefinitionProvider(engine),
     provideDocumentFormattingEdits: embeddedDocumentFormattingProvider(engine),
@@ -115,9 +116,6 @@ export async function activateLsp(
   if (config.get("cells.signatureHelp.enabled", true)) {
     middleware.provideSignatureHelp = embeddedSignatureHelpProvider(engine);
   }
-  if (config.get("vdoc.hideDiagnostics", true)) {
-    middleware.handleDiagnostics = createDiagnosticFilter();
-  }
   extensionHost().registerStatementRangeProvider(engine);
   extensionHost().registerHelpTopicProvider(engine);