Force a user save on untitled documents, before switch to visual mode #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For more background on why we have a special command in Positron for this kind of switch, see #684 |
|
Thanks for adding a period for my #823 changelog note :) |
vezwork
approved these changes
Oct 1, 2025
Comment on lines
133
to
145
| // save then close | ||
| await commands.executeCommand("workbench.action.files.save"); | ||
| await commands.executeCommand('workbench.action.closeActiveEditor'); | ||
| VisualEditorProvider.recordPendingSwitchToVisual(document); | ||
| // open in visual mode | ||
| await commands.executeCommand("vscode.openWith", | ||
| document.uri, | ||
| VisualEditorProvider.viewType, | ||
| { | ||
| viewColumn | ||
| } | ||
| ); | ||
| } |
There was a problem hiding this comment.
Suggested change
| workspace.onDidSaveTextDocument(async (doc: TextDocument) => { | |
| VisualEditorProvider.recordPendingSwitchToVisual(doc); | |
| // open in visual mode | |
| await commands.executeCommand('workbench.action.closeActiveEditor'); | |
| await commands.executeCommand("vscode.openWith", | |
| doc.uri, | |
| VisualEditorProvider.viewType, | |
| { viewColumn } | |
| ); | |
| }); | |
| // save then close | |
| await commands.executeCommand("workbench.action.files.save") |
Here's a fix for VSCode.
There was a problem hiding this comment.
I think I accidentally didn't remove the old code in the suggested change.
There was a problem hiding this comment.
@juliasilge I can push this fix for VSCode to the branch if it looks good.
There was a problem hiding this comment.
Yes, that would be great! Feel free to push an additional fix.
|
Oh, I seem to have lost my insert edit: made a PR to make that config part of the repo #837 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #827
Untitled files cannot be edited in visual mode; we actually have a whole special set of screens to show people about this:
https://github.com/search?q=repo%3Aquarto-dev%2Fquarto%20untitled_document_cannot_be_edited&type=code
The new Positron-specific command we made to help with these switches
positron.reopenWithis working generally well, but it doesn't know about this special Quarto rule. If we have an untitled document here, let's force the user to save before switching.