overview documentation of the extension #857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezwork
changed the title
vezwork
commented
Oct 24, 2025
Comment on lines
+125
to
+132
| createPreviewPanel: ( | ||
| viewType: string, | ||
| title: string, | ||
| preserveFocus?: boolean, | ||
| options?: WebviewPanelOptions & WebviewOptions | ||
| ): WebviewPanel => { | ||
| return window.createWebviewPanel(viewType, title, { viewColumn: ViewColumn.Beside, preserveFocus, }, options); | ||
| } |
There was a problem hiding this comment.
This was previously imported from preview.ts where it was defined by itself. I found that hard to navigate and also the implementation of this function in the other ExtensionHost in hooks.ts defines this inline.
vezwork
commented
Oct 24, 2025
| private async hasExecutorForLanguage(language: string, document: TextDocument, engine: MarkdownEngine) { | ||
| // TODO: this is incorrect right? `cellExecutorForLanguage` returns a promise, and a promise will always be truthy? | ||
| // We should have to await it before doing `!!` | ||
| return !!this.cellExecutorForLanguage(language, document, engine); |
There was a problem hiding this comment.
Didn't want to make a change here because it will change the logic, so I left a TODO so I don't forget the next time I'm working in this area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some added inline docs, minor refactors, and a large overview markdown file that links to various key places in the code and gives some examples of how parts of the extension communicate with eachother. The inline docs and minor refactors mostly aim to address places I have been getting stuck/lost repeatedly while navigating code over the past few months.
I did this to help me get re-oriented, and to be able to answer questions about how to architect #825 and future features that involve "piping things through" (sharing functionality between the Source Editor and Visual Editor by communicating from the Visual Editor to the host and LSP in a consistent way).