testing(internal/godocfx): convert equality check to a diff check (googleapis#13089)

shollyman · web-flow · commit 193051184828 · 2025-10-10T11:14:04.000-07:00
towards: googleapis#12922
diff --git a/internal/godocfx/godocfx_test.go b/internal/godocfx/godocfx_test.go
@@ -174,8 +174,8 @@ func TestGoldens(t *testing.T) {
 			t.Fatalf("failed to read golden: %v", err)
 		}
 
-		if string(gotContent) != string(goldenContent) {
-			t.Errorf("got %s is different from expected %s", gotPath, goldenPath)
+		if diff := cmp.Diff(goldenContent, gotContent); diff != "" {
+			t.Errorf("diff with golden (%q,%q) (-want +got):\n\n%s", goldenPath, gotPath, diff)
 		}
 
 		return nil

Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,8 @@ func TestGoldens(t *testing.T) {`
`174`	`174`	`t.Fatalf("failed to read golden: %v", err)`
`175`	`175`	`}`
`176`	`176`
`177`		`- if string(gotContent) != string(goldenContent) {`
`178`		`- t.Errorf("got %s is different from expected %s", gotPath, goldenPath)`
	`177`	`+ if diff := cmp.Diff(goldenContent, gotContent); diff != "" {`
	`178`	`+ t.Errorf("diff with golden (%q,%q) (-want +got):\n\n%s", goldenPath, gotPath, diff)`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`return nil`