Skip to content

Commit d7ee725

Browse files
authored
testing(bigquery/storage/managedwriter): fix go-cmp diff usage (googleapis#11459)
This switches usage of sync.Mutex in options testing from allowing unexported to ignoring outright. There's chances to sync in the latest versions of go head that aren't compatible with AllowUnexported, and the comparison isn't relevant to the code under test.
1 parent e33ceb4 commit d7ee725

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

bigquery/storage/managedwriter/options_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ func TestWriterOptions(t *testing.T) {
342342

343343
if diff := cmp.Diff(got, tc.want,
344344
cmp.AllowUnexported(ManagedStream{}, streamSettings{}),
345-
cmp.AllowUnexported(sync.Mutex{}),
345+
cmpopts.IgnoreTypes(sync.Mutex{}),
346346
cmp.AllowUnexported(versionedTemplate{}),
347347
cmpopts.IgnoreFields(versionedTemplate{}, "versionTime", "hashVal"),
348348
protocmp.Transform(), // versionedTemplate embeds proto messages.

0 commit comments

Comments
 (0)