chore: migrate monorepo to eslint v9 (#17934)

* chore: migrate to eslint v9

* chore: make more changes for eslint v9 migration

* chore: enable cache for eslint

* chore(vite-plugin): consolidate eslint config

* chore: adjust jsconfig files

* chore(docs): remove outdated stylintrc file
which was for Stylus

* chore: include all projects in VS Code ESLint extension
and simplify it by using mode: auto

* chore: exclude dist directories from VS Code search

* chore: remove failing postinstall script
which runs quasar prepare, which requires ui package to be built due to logic in vite-plugin
removing at least until #17935 gets merged

* chore: rename prepare to prepare:types to avoid unintentional runs
forgot prepare was a special script

Author: yusufkandemir

.eslintignore

@@ -9,3 +9,5 @@ ui/.vscode/
 node_modules/
 yarn.lock
 package-lock.json
+
+.eslintcache

.eslintrc.cjs

@@ -2,19 +2,15 @@
   "eslint.format.enable": false,
   "editor.formatOnSave": false,
   "eslint.workingDirectories": [
-    "./app-vite",
-    "./app-webpack",
-    "./cli",
-    "./create-quasar",
-    "./docs",
-    "./ui",
-    "./utils/render-ssr-error",
-    "./utils/ssl-certificate",
-    "./vite-plugin"
+    { "mode": "auto" }
   ],
   "editor.tabSize": 2,
   "editor.codeActionsOnSave": {
     "source.fixAll.eslint": "explicit"
   },
-  "eslint.validate": ["javascript", "vue"]
+  "eslint.validate": ["javascript", "vue"],
+
+  "search.exclude": {
+    "**/dist": true,
+  }
 }

.gitignore

@@ -0,0 +1,79 @@
+// eslint-disable-next-line n/no-extraneous-import
+import eslintJs from '@eslint/js'
+import quasar from 'eslint-config-quasar'
+// eslint-disable-next-line n/no-extraneous-import
+import globals from 'globals'
+
+/** @type {import('eslint').Linter.Config[]} */
+export default [
+  {
+    name: 'eslint/recommended',
+
+    ...eslintJs.configs.recommended
+  },
+
+  ...quasar.configs.base,
+
+  {
+    ignores: [
+      'templates',
+    ]
+  },
+
+  {
+    languageOptions: {
+      sourceType: 'module'
+    },
+
+    rules: {
+      'no-useless-escape': 'off',
+      'no-unused-vars': [ 'error', { ignoreRestSiblings: true, argsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' } ]
+    }
+  },
+
+  ...[
+    ...quasar.configs.node
+  ].map(({ name: _, ...config }) => ({
+    ...config,
+    files: [ '**/*.js' ],
+    ignores: [ 'exports/bex/**/*.js' ]
+  })),
+  {
+    files: [ '**/*.js' ],
+    ignores: [ 'exports/bex/**/*.js' ],
+
+    languageOptions: {
+      sourceType: 'module',
+      ecmaVersion: 2022, // needs to be explicitly stated for some reason
+      // TODO: ^ verify if it's still needed
+
+      globals: {
+        ...globals.es2022,
+        // ...globals.es2023, // node 22 and above
+      }
+    },
+  },
+
+  {
+    files: [ '**/*.cjs' ],
+    languageOptions: {
+      parserOptions: {
+        sourceType: 'commonjs',
+        ecmaVersion: 'latest'
+      }
+    }
+  },
+
+  {
+    files: [ 'exports/bex/**/*.js' ],
+    languageOptions: {
+      parserOptions: {
+        ecmaVersion: 'latest',
+      },
+      globals: {
+        ...globals.browser,
+        ...globals.webextensions
+      }
+    }
+  }
+]

.vscode/settings.json

@@ -158,7 +158,7 @@ export class InstallAPI extends BaseAPI {
           fs.readFileSync(source, 'utf-8')
         )
       }
-      catch (e) {
+      catch (_) {
         warn(`Extension(${ this.extId }): extendPackageJson() - "${ extPkg }" is malformed`)
         warn()
         process.exit(1)
@@ -217,7 +217,7 @@ export class InstallAPI extends BaseAPI {
           'utf-8'
         )
       }
-      catch (e) {
+      catch (_) {
         warn()
         warn(`Extension(${ this.extId }): extendJsonFile() - "${ filePath }" doesn't conform to JSON format: this could happen if you are trying to update flavoured JSON files (eg. JSON with Comments or JSON5). Skipping...`)
         warn(`Extension(${ this.extId }): extendJsonFile() - The extension tried to apply these updates to "${ filePath }" file: ${ JSON.stringify(newData) }`)

app-vite/.eslintignore

@@ -37,7 +37,7 @@ function getSpawnOutput (command) {
       ? green(String(child.output[ 1 ]).trim())
       : gray('Not installed')
   }
-  catch (err) {
+  catch (_) {
     return gray('Not installed')
   }
 }

app-vite/.eslintrc.cjs

@@ -21,7 +21,7 @@ export async function ensureDeps ({ appPaths, cacheProxy }) {
   nodePackager.install({
     cwd: appPaths.capacitorDir,
     // See https://github.com/orgs/pnpm/discussions/4735
-    params: nodePackager.name === 'pnpm' ? ['i', '--ignore-workspace'] : undefined,
+    params: nodePackager.name === 'pnpm' ? [ 'i', '--ignore-workspace' ] : undefined,
     displayName: 'Capacitor'
   })
 }