Race condition when running tests

[jrha]

This is occasionally seen in both the GitHub runners and my local build environments.

Dubious, test returned 1 (wstat 256, 0x100)

Some snippets from the logs that might be related:

Direct usage of EDG::WP4::CCM::Element is deprecated and contains no functional code besides a limited number of reexported functions and constants from other modules. at /quattor_test/quattordev/install/usr/lib/perl/EDG/WP4/CCM/Element.pm line 35.

Uncaught exception!!! Calling stack is:
LC::Exception::throw_error called at /quattor_test/quattordev/install/usr/lib/perl/LC/File.pm line 149
LC::File::file_contents called at /quattor_test/quattordev/install/usr/lib/perl/CAF/FileWriter.pm line 607
CAF::FileWriter::_read_contents called at /quattor_test/quattordev/install/usr/lib/perl/CAF/FileWriter.pm line 304
CAF::FileWriter::close called at /quattor_test/quattordev/install/usr/lib/perl/CAF/FileWriter.pm line 641
CAF::FileWriter::DESTROY called at src/test/perl/raid-ks.t line 0
(eval) called at src/test/perl/raid-ks.t line 0
*** open(target/test/ksfs): No such file or directory

[jrha]

Seems to affect other tests too:

 Uncaught exception!!! Calling stack is:
  LC::Exception::throw_error called at /usr/lib/perl/LC/File.pm line 149
  LC::File::file_contents called at /usr/lib/perl/CAF/FileWriter.pm line 607
  CAF::FileWriter::_read_contents called at /usr/lib/perl/CAF/FileWriter.pm line 304
  CAF::FileWriter::close called at /usr/lib/perl/CAF/FileWriter.pm line 641
  CAF::FileWriter::DESTROY called at src/test/perl/disk_size.t line 0
  (eval) called at src/test/perl/disk_size.t line 0
*** open(target/test/ksdisksize): No such file or directory
src/test/perl/disk_size.t ....................... 

[jrha]

This may be related to the very old build tools being used until #109 was merged, we will see.

[jrha]

Seen again today with yet another test:

Uncaught exception!!! Calling stack is:
LC::Exception::throw_error called at /quattor_test/quattordev/install/usr/lib/perl/LC/File.pm line 149
LC::File::file_contents called at /quattor_test/quattordev/install/usr/lib/perl/CAF/FileWriter.pm line 607
CAF::FileWriter::_read_contents called at /quattor_test/quattordev/install/usr/lib/perl/CAF/FileWriter.pm line 304
CAF::FileWriter::close called at /quattor_test/quattordev/install/usr/lib/perl/CAF/FileWriter.pm line 641
CAF::FileWriter::DESTROY called at src/test/perl/partition_gpt_partition_flags.t line 0
(eval) called at src/test/perl/partition_gpt_partition_flags.t line 0
*** open(target/test/ks): No such file or directory

Test Summary Report
-------------------
src/test/perl/partition_gpt_partition_flags.t (Wstat: 256 Tests: 4 Failed: 0)
Non-zero exit status: 1
Files=17, Tests=529, 65 wallclock secs ( 0.17 usr  0.06 sys + 57.17 cusr  5.52 csys = 62.92 CPU)
Result: FAIL

[jrha]

I think I've finally found the root cause of the race conditions, all the tests that exhibit it use select to swap out file handles before tests and restore them afterwards.