Change value of 'model' field to real model name in CPU templates

[bmcann]

Hi Folks,

I propose that we change the value of the model field in the CPU templates to the real model name of the CPU and assign the current value of model to the name key. This would bring the CPU templates into line with the NIC templates and allow us to more easily use conditional logic on matching a value of CPU model to provide extra config if required. So for example, what I propose is:

Change from:

structure template hardware/cpu/intel/xeon_e5_2650v3;

"manufacturer" = "Intel";
"model" = "Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30 GHz";
"speed" = 2300; # MHz
"arch" = "x86_64";
"cores" = 10;
"max_threads" = 20;
"type" = "haswell"; # Intel codename
"power" = 105; # TDP in watts

to

structure template hardware/cpu/intel/xeon_e5_2650v3;

"manufacturer" = "Intel";
"model" = "xeon_e5_2650v3";
"name" = "Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30 GHz";
"speed" = 2300; # MHz
"arch" = "x86_64";
"cores" = 10;
"max_threads" = 20;
"type" = "haswell"; # Intel codename
"power" = 105; # TDP in watts

For extra consistency, I also propose changing the case of the manufacturer value to all lower case.

Comments please.

[jrha]

Please don't try and do this manually, instead modify ark2pan.

I don't disagree, but it was done this way to match existing templates, so changing it would be a user-facing backward compatibility issue.

[bmcann]

Don't worry, I had no intention of doing this manually and I understand why the approach taken. I thought it was worth putting in the proposition so you can discuss it at the workshop if there is room in the agenda. Yes it is backwards incompatible, but if no-one is using it, it isn't a problem.