profiles: Preemptive pull workload images

Signed-off-by: Paulo Gomes <[email protected]>

Author: pjbgf

internal/images/images.go

@@ -1,9 +1,7 @@
 package images
 
 import (
-	"errors"
 	"fmt"
-	"io/fs"
 	"log/slog"
 	"os"
 	"sync"
@@ -53,7 +51,7 @@ func pullExpired() (bool, error) {
 	fn := files.ImagesLastCheckedPath()
 	fi, err := os.Stat(fn)
 	if err != nil {
-		if !errors.Is(err, fs.ErrNotExist) {
+		if !os.IsNotExist(err) {
 			return false, fmt.Errorf("cannot stat %q: %w", fn, err)
 		}
 		if err := os.WriteFile(fn, []byte{}, files.FileMode); err != nil {
@@ -76,6 +74,19 @@ func pullExpired() (bool, error) {
 	return false, nil
 }
 
+func PreemptWorkloadImages(cfg *types.Config) {
+	slog.Debug("Check need for the preemptive pull of workload images")
+	fn := files.ImagesLastCheckedPath()
+
+	_, err := os.Stat(fn)
+	if err != nil && os.IsNotExist(err) {
+		fmt.Println("INFO: Preemptively pulling workload images. This only happens on first execution and aims to avoid delays opening apps.")
+
+		_ = PullAll(cfg)
+		_ = os.WriteFile(fn, []byte{}, files.FileMode)
+	}
+}
+
 func PullAll(cfg *types.Config) error {
 	wf, err := cfg.WorkloadFiles()
 	if err != nil {

internal/profiles/profiles.go

@@ -74,8 +74,15 @@ func validGitDir(path string) bool {
 
 func StartFromGit(name, gitURL, path, local string) error {
 	ln := files.ProfileConfig(name)
+
 	if _, err := os.Lstat(ln); err == nil {
-		return fmt.Errorf("profile %q is already started", name)
+		// Wayland is not cleaning up profile state after closure.
+		if !strings.EqualFold(os.Getenv("XDG_SESSION_TYPE"), "wayland") {
+			return fmt.Errorf("profile %q is already started", name)
+		}
+		if err = os.Remove(ln); err != nil {
+			return fmt.Errorf("failed to remove leftover profile symlink: %w", err)
+		}
 	}
 
 	dir, err := files.GitDirPath(gitURL)
@@ -177,11 +184,18 @@ func Start(profile *types.Profile, cfg *types.Config) (err error) {
 		return err
 	}
 
+	fi, err := os.Lstat(files.ContainerRunnerBinary)
+	if err != nil || !fi.Mode().IsRegular() {
+		return fmt.Errorf("could not find docker or podman")
+	}
+
 	err = images.PullImageIfNotPresent(profile.Image)
 	if err != nil {
 		return fmt.Errorf("cannot pull profile image: %w", err)
 	}
 
+	go images.PreemptWorkloadImages(cfg)
+
 	if profile.Gpus != "" {
 		if !gpu.Supported() {
 			profile.Gpus = ""
@@ -225,6 +239,7 @@ func Start(profile *types.Profile, cfg *types.Config) (err error) {
 				err = err1
 			}
 		}
+
 		wg.Done()
 	}()
 

internal/types/config.go

@@ -187,6 +187,8 @@ func LoadConfig(path string) (*Config, error) {
 		return nil, fmt.Errorf("cannot unmarshal qubesome config %q: %w", path, err)
 	}
 
+	cfg.RootDir = filepath.Dir(path)
+
 	// To avoid names being defined twice on the profiles, the name
 	// is only defined when referring to a profile which results
 	// on the .name field of Profiles not being populated.