Support runner override, zsh autocomplete and build improvements (#6)

Author: pjbgf

.github/dependabot.yaml

@@ -0,0 +1,11 @@
+version: 2
+updates:
+  - package-ecosystem: "gomod"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/workflows/release.yml

@@ -5,14 +5,17 @@ on:
     tags:
       - "v*"
 
-permissions:
-  contents: write # create GH releases
-  id-token: write # ephemeral keys (a.k.a. "keyless") signing
+permissions: {}
 
 jobs:
   goreleaser:
     runs-on: ubuntu-latest
 
+    permissions:
+      contents: write # create GH releases
+      id-token: write # ephemeral keys (a.k.a. "keyless") signing
+      attestations: write # write GH attestations
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -24,14 +27,19 @@ jobs:
         with:
           go-version: stable
 
-      - uses: anchore/sbom-action/download-syft@v0.15.0
-      - uses: sigstore/cosign-installer@v3.4.0
+      - uses: anchore/sbom-action/download-syft@v0.17.7
+      - uses: sigstore/cosign-installer@v3.7.0
 
       - name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v5
+        uses: goreleaser/goreleaser-action@v6
         with:
           distribution: goreleaser
-          version: latest
+          version: '~> v2'
           args: release --clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Attest release artefacts
+        uses: actions/attest-build-provenance@v1
+        with:
+          subject-path: "dist/qubesome*"

.github/workflows/test.yml

@@ -3,13 +3,15 @@ name: tests
 on:
   push:
 
-permissions:
-  contents: read
+permissions: {}
 
 jobs:
   tests:
     runs-on: ubuntu-latest
 
+    permissions:
+      contents: read
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4

.goreleaser.yaml

@@ -1,3 +1,4 @@
+version: 2
 project_name: qubesome
 builds:
   - id: qubesome

README.md

@@ -24,7 +24,7 @@ go install github.com/qubesome/cli/cmd/qubesome@latest
 
 ##### For Tumbleweed users
 ```
-zypper install qubesome
+zypper install -y qubesome
 ```
 
 #### Start Profile
@@ -45,7 +45,7 @@ To transfer clipboards between profiles use `qubesome clipboard`.
 
 Check whether dependency requirements are met:
 ```
-qubesome deps show
+qubesome deps
 ```
 
 Use a local copy, and if not found fallback to a fresh clone:
@@ -129,8 +129,8 @@ Ability to control network/internet access for each workload, and run the window
 manager without internet access. Auditing access violations, for visibility of when
 workloads are trying to access things they should not.
 
-#### Is Rootless docker support?
-Not at this point, potentially this could be introduced in the future.
+#### Is rootless supported?
+Yes, but only with podman.
 
 ### Why do I need to run xhost +SI:localuser:${USER}?
 Some Linux distros (e.g. Tumbleweed) have X11 access controls enabled

cmd/cli/autocomplete/zsh_autocomplete

@@ -0,0 +1,23 @@
+#compdef qubesome
+compdef _qubesome qubesome
+
+_qubesome() {
+	local -a opts
+	local cur
+	cur=${words[-1]}
+	if [[ "$cur" == "-"* ]]; then
+		opts=("${(@f)$(${words[@]:0:#words[@]-1} ${cur} --generate-shell-completion)}")
+	else
+		opts=("${(@f)$(${words[@]:0:#words[@]-1} --generate-shell-completion)}")
+	fi
+
+	if [[ "${opts[1]}" != "" ]]; then
+		_describe 'values' opts
+	else
+		_files
+	fi
+}
+
+if [ "$funcstack[1]" = "_qubesome" ]; then
+	_qubesome
+fi

cmd/cli/completion.go

@@ -0,0 +1,25 @@
+package cli
+
+import (
+	"context"
+	_ "embed"
+	"fmt"
+
+	"github.com/urfave/cli/v3"
+)
+
+//go:embed autocomplete/zsh_autocomplete
+var autocompleteZSH string
+
+func completionCommand() *cli.Command {
+	cmd := &cli.Command{
+		Name:      "autocomplete",
+		Usage:     "Generate autocomplete",
+		UsageText: "source <(qubesome autocomplete)",
+		Action: func(ctx context.Context, cmd *cli.Command) error {
+			fmt.Println(autocompleteZSH)
+			return nil
+		},
+	}
+	return cmd
+}

cmd/cli/images.go

@@ -20,11 +20,18 @@ func imagesCommand() *cli.Command {
 						Name:        "profile",
 						Destination: &targetProfile,
 					},
+					&cli.StringFlag{
+						Name:        "runner",
+						Destination: &runner,
+					},
 				},
 				Action: func(ctx context.Context, cmd *cli.Command) error {
 					cfg := profileConfigOrDefault(targetProfile)
 
-					return images.Run(images.WithConfig(cfg))
+					return images.Run(
+						images.WithConfig(cfg),
+						images.WithRunner(runner),
+					)
 				},
 			},
 		},

cmd/cli/root.go

@@ -18,6 +18,7 @@ var (
 	workload      string
 	path          string
 	local         string
+	runner        string
 	debug         bool
 )
 
@@ -31,6 +32,7 @@ func RootCommand() *cli.Command {
 			xdgCommand(),
 			depsCommand(),
 			versionCommand(),
+			completionCommand(),
 		},
 	}
 

cmd/cli/run.go

@@ -24,6 +24,10 @@ func runCommand() *cli.Command {
 				Name:        "profile",
 				Destination: &targetProfile,
 			},
+			&cli.StringFlag{
+				Name:        "runner",
+				Destination: &runner,
+			},
 		},
 		Usage: "execute workloads",
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -33,6 +37,7 @@ func runCommand() *cli.Command {
 				qubesome.WithWorkload(workload),
 				qubesome.WithProfile(targetProfile),
 				qubesome.WithConfig(cfg),
+				qubesome.WithRunner(runner),
 				qubesome.WithExtraArgs(cmd.Args().Slice()),
 			)
 		},