start: Refactor Config loading

Config loading needs to behave in different ways than other
commands like xdg-open and run. Move it inside the start package instead.

Signed-off-by: Paulo Gomes <[email protected]>

Author: pjbgf

cmd/cli/root.go

@@ -87,6 +87,7 @@ func profileConfigOrDefault(profile string) *types.Config {
 		// Try to load the profile specific config.
 		path := files.ProfileConfig(profile)
 		target, err := os.Readlink(path)
+		slog.Debug("try to load profile config", "profile", profile, "path", path, target, "target")
 
 		if err == nil {
 			c := config(target)

cmd/cli/start.go

@@ -47,10 +47,7 @@ qubesome start -git https://github.com/qubesome/sample-dotfiles i3
 			},
 		},
 		Action: func(ctx context.Context, cmd *cli.Command) error {
-			cfg := profileConfigOrDefault(targetProfile)
-
 			return profiles.Run(
-				profiles.WithConfig(cfg),
 				profiles.WithProfile(targetProfile),
 				profiles.WithGitURL(gitURL),
 				profiles.WithPath(path),

internal/profiles/options.go

@@ -2,7 +2,6 @@ package profiles
 
 import (
 	"github.com/qubesome/cli/internal/command"
-	"github.com/qubesome/cli/internal/types"
 )
 
 type Options struct {
@@ -11,7 +10,6 @@ type Options struct {
 	Local   string
 	Profile string
 	Runner  string
-	Config  *types.Config
 }
 
 func WithGitURL(gitURL string) command.Option[Options] {
@@ -37,11 +35,6 @@ func WithProfile(profile string) command.Option[Options] {
 		o.Profile = profile
 	}
 }
-func WithConfig(config *types.Config) command.Option[Options] {
-	return func(o *Options) {
-		o.Config = config
-	}
-}
 
 func WithRunner(runner string) command.Option[Options] {
 	return func(o *Options) {

internal/profiles/profiles.go

@@ -45,15 +45,25 @@ func Run(opts ...command.Option[Options]) error {
 		return StartFromGit(o.Runner, o.Profile, o.GitURL, o.Path, o.Local)
 	}
 
-	if o.Config == nil {
+	path := filepath.Join(o.Local, o.Path, "qubesome.config")
+	if _, err := os.Stat(path); err != nil {
+		return err
+	}
+	cfg, err := types.LoadConfig(path)
+	if err != nil {
+		return err
+	}
+	cfg.RootDir = filepath.Dir(path)
+
+	if cfg == nil {
 		return fmt.Errorf("cannot start profile: nil config")
 	}
-	profile, ok := o.Config.Profile(o.Profile)
+	profile, ok := cfg.Profile(o.Profile)
 	if !ok {
 		return fmt.Errorf("cannot start profile: profile %q not found", o.Profile)
 	}
 
-	return Start(o.Runner, profile, o.Config)
+	return Start(o.Runner, profile, cfg)
 }
 
 func validGitDir(path string) bool {