check for duplicate digest in txs pool add (#597)

* check for duplicate digest in txs pool add

Author: Franziska-Mueller

src/platform/debugging.h

@@ -2,6 +2,7 @@
 
 #include "assert.h"
 #include "concurrency.h"
+#include "console_logging.h"
 #include "file_io.h"
 
 

src/platform/file_io.h

@@ -8,10 +8,10 @@
 #include <lib/platform_common/processor.h>
 #include <lib/platform_common/compiler_optimization.h>
 #include <lib/platform_efi/uefi.h>
+
 #include "console_logging.h"
 #include "concurrency.h"
 #include "memory.h"
-#include "debugging.h"
 
 // If you get an error reading and writing files, set the chunk sizes below to
 // the cluster size set for formatting you disk. If you have no idea about the
@@ -33,7 +33,9 @@ static constexpr int ASYNC_FILE_IO_MAX_QUEUE_ITEMS = (1ULL << ASYNC_FILE_IO_MAX_
 static EFI_FILE_PROTOCOL* root = NULL;
 class AsyncFileIO;
 static AsyncFileIO* gAsyncFileIO = NULL;
+
 static void addDebugMessage(const CHAR16* msg);
+
 static long long getFileSize(CHAR16* fileName, CHAR16* directory = NULL)
 {
 #ifdef NO_UEFI

src/platform/virtual_memory.h

@@ -5,6 +5,7 @@
 #include "platform/time.h"
 #include "platform/memory_util.h"
 #include "platform/debugging.h"
+#include "platform/file_io.h"
 
 #include "four_q.h"
 #include "kangaroo_twelve.h"

src/ticking/pending_txs_pool.h

@@ -5,6 +5,7 @@
 #include "platform/memory_util.h"
 #include "platform/concurrency.h"
 #include "platform/console_logging.h"
+#include "platform/debugging.h"
 
 #include "spectrum/spectrum.h"
 
@@ -258,17 +259,32 @@ class PendingTxsPool
             unsigned int tickIndex = tickToIndex(tx->tick);
             const unsigned int transactionSize = tx->totalSize();
 
+            // check if tx with same digest already exists
+            m256i digest;
+            KangarooTwelve(tx, transactionSize, &digest, sizeof(m256i));
+            for (unsigned int txIndex = 0; txIndex < numSavedTxsPerTick[tickIndex]; ++txIndex)
+            {
+                if (*getDigestPtr(tickIndex, txIndex) == digest)
+                {
+#if !defined(NDEBUG) && !defined(NO_UEFI)
+                    CHAR16 dbgMsgBuf[100];
+                    setText(dbgMsgBuf, L"tx with the same digest already exists for tick ");
+                    appendNumber(dbgMsgBuf, tx->tick, FALSE);
+                    addDebugMessage(dbgMsgBuf);
+#endif
+                    goto end_add_function;
+                }
+            }
+
             sint64 priority = calculateTxPriority(tx);
             if (priority > 0)
             {
                 m256i povIndex{ tickIndex, 0, 0, 0 };
 
                 if (numSavedTxsPerTick[tickIndex] < maxNumTxsPerTick)
                 {
-                    KangarooTwelve(tx, transactionSize, getDigestPtr(tickIndex, numSavedTxsPerTick[tickIndex]), sizeof(m256i));
-
+                    copyMem(getDigestPtr(tickIndex, numSavedTxsPerTick[tickIndex]), &digest, sizeof(m256i));
                     copyMem(getTxPtr(tickIndex, numSavedTxsPerTick[tickIndex]), tx, transactionSize);
-
                     txsPriorities->add(povIndex, numSavedTxsPerTick[tickIndex], priority);
 
                     numSavedTxsPerTick[tickIndex]++;
@@ -286,8 +302,7 @@ class PendingTxsPool
                             txsPriorities->remove(lowestElementIndex);
                             txsPriorities->add(povIndex, replacedTxIndex, priority);
 
-                            KangarooTwelve(tx, transactionSize, getDigestPtr(tickIndex, replacedTxIndex), sizeof(m256i));
-
+                            copyMem(getDigestPtr(tickIndex, replacedTxIndex), &digest, sizeof(m256i));
                             copyMem(getTxPtr(tickIndex, replacedTxIndex), tx, transactionSize);
 
                             txAdded = true;
@@ -326,13 +341,15 @@ class PendingTxsPool
 #if !defined(NDEBUG) && !defined(NO_UEFI)
             else
             {
-                CHAR16 dbgMsgBuf[300];
+                CHAR16 dbgMsgBuf[100];
                 setText(dbgMsgBuf, L"tx with priority 0 was rejected for tick ");
                 appendNumber(dbgMsgBuf, tx->tick, FALSE);
                 addDebugMessage(dbgMsgBuf);
             }
 #endif
         }
+
+    end_add_function:
         RELEASE(lock);
 
 #if !defined(NDEBUG) && !defined(NO_UEFI)