simplified max tick computation by not relying on a 2nd max tick

Author: 0xluk

node/container.go

@@ -53,9 +53,6 @@ func (c *Container) Update() error {
 	log.Printf("Refreshing nodes...\n")
 
 	onlineNodes := fetchOnlineNodes(c.Addresses, c.Port, c.connectionTimeout)
-	slices.SortFunc(onlineNodes, func(a, b *Node) int {
-		return cmp.Compare(a.LastTick, b.LastTick)
-	})
 	maxTick := calculateMaxTick(onlineNodes, c.TickErrorThreshold)
 
 	reliableNodes, mostReliableNode := getReliableNodes(onlineNodes, maxTick, maxTick-c.ReliableTickRange)
@@ -114,24 +111,17 @@ func fetchOnlineNodes(addresses []string, port string, connectionTimeout time.Du
 }
 
 func calculateMaxTick(nodes []*Node, threshold uint32) uint32 {
+	slices.SortFunc(nodes, func(a, b *Node) int {
+		return cmp.Compare(a.LastTick, b.LastTick)
+	})
 
 	arrayLength := len(nodes)
 
 	if arrayLength == 0 {
 		return 0
 	}
 
-	if arrayLength < 2 {
-		return nodes[0].LastTick
-	}
-
-	maxTick := nodes[len(nodes)-1].LastTick
-	maxTick2 := nodes[len(nodes)-2].LastTick
-
-	if maxTick2 != 0 && (maxTick-maxTick2) >= threshold {
-		return maxTick2
-	}
-	return maxTick
+	return nodes[arrayLength-1].LastTick
 }
 
 func getReliableNodes(onlineNodes []*Node, maximum, minimum uint32) ([]*Node, *Node) {

node/container_test.go

@@ -84,7 +84,7 @@ func TestMaxTick(t *testing.T) {
 					LastUpdateSuccess: true,
 				},
 			},
-			want:      2000,
+			want:      3000,
 			threshold: 50,
 		},
 		{
@@ -159,7 +159,7 @@ func TestMaxTick(t *testing.T) {
 					LastUpdateSuccess: true,
 				},
 			},
-			want:      2000,
+			want:      2050,
 			threshold: 50,
 		},
 		{
@@ -237,6 +237,122 @@ func TestMaxTick(t *testing.T) {
 			want:      2049,
 			threshold: 50,
 		},
+		{
+			name: "TestMaxTick_4",
+			nodes: []*Node{
+				{
+					Address:           "",
+					Peers:             nil,
+					LastTick:          1021,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				},
+				{
+					Address:           "",
+					Peers:             nil,
+					LastTick:          1000,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				},
+				{
+					Address:           "",
+					Peers:             nil,
+					LastTick:          1023,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				},
+				{
+					Address:           "",
+					Peers:             nil,
+					LastTick:          1023,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				},
+				{
+					Address:           "",
+					Peers:             nil,
+					LastTick:          2500,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				},
+				{
+					Address:           "",
+					Peers:             nil,
+					LastTick:          5700,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				}, {
+					Address:           "",
+					Peers:             nil,
+					LastTick:          100,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				},
+				{
+					Address:           "",
+					Peers:             nil,
+					LastTick:          1945,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				},
+				{
+					Address:           "",
+					Peers:             nil,
+					LastTick:          2000,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				}, {
+					Address:           "",
+					Peers:             nil,
+					LastTick:          3000,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				},
+			},
+			want:      5700,
+			threshold: 50,
+		},
+		{
+			name: "TestMaxTick_5",
+			nodes: []*Node{
+				{
+					Address:           "",
+					Peers:             nil,
+					LastTick:          1000,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				},
+			},
+			want:      1000,
+			threshold: 50,
+		},
+		{
+			name: "TestMaxTick_6",
+			nodes: []*Node{
+				{
+					Address:           "",
+					Peers:             nil,
+					LastTick:          1500,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				},
+				{
+					Address:           "",
+					Peers:             nil,
+					LastTick:          1000,
+					LastUpdate:        0,
+					LastUpdateSuccess: true,
+				},
+			},
+			want:      1500,
+			threshold: 50,
+		},
+		{
+			name:      "TestMaxTick_7",
+			nodes:     []*Node{},
+			want:      0,
+			threshold: 50,
+		},
 	}
 
 	for _, test := range testData {