Skip to content

Commit 45b7b46

Browse files
committed
fix: fixing code smell
1 parent e2faa5d commit 45b7b46

File tree

8 files changed

+21
-26
lines changed

8 files changed

+21
-26
lines changed

package.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,12 @@
187187
"webpack-merge": "^5.8.0"
188188
},
189189
"build": {
190+
"protocols": {
191+
"name": "QueryMaster",
192+
"schemes": [
193+
"querymaster"
194+
]
195+
},
190196
"productName": "QueryMaster",
191197
"appId": "com.invisal.querymaster",
192198
"asar": true,

src/libs/NotImplementCallback.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
export default function NotImplementCallback<T = void>(): T {
2-
throw 'Not implemented';
2+
throw new Error('Not implemented');
33
}

src/libs/QueryBuilder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ export class QueryBuilder {
251251
}
252252
}
253253

254-
throw 'not implemented';
254+
throw new Error('Not implemented');
255255
}
256256

257257
toRawSQL() {

src/renderer/contexts/AppFeatureProvider.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import NotImplementCallback from 'libs/NotImplementCallback';
12
import {
23
PropsWithChildren,
34
createContext,
@@ -19,12 +20,8 @@ const AppFeatureContext = createContext<{
1920
theme: 'light',
2021
enableDebug: false,
2122

22-
setTheme: () => {
23-
throw 'Not implemented';
24-
},
25-
setEnableDebug: () => {
26-
throw 'Not implemented';
27-
},
23+
setTheme: NotImplementCallback
24+
setEnableDebug: NotImplementCallback,
2825
});
2926

3027
export function useAppFeature() {

src/renderer/contexts/DatabaseSettingProvider.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { ConnectionStoreItem } from 'drivers/base/SQLLikeConnection';
2+
import NotImplementCallback from 'libs/NotImplementCallback';
23
import {
34
PropsWithChildren,
45
createContext,
@@ -14,9 +15,7 @@ const DatabaseSettingContext = createContext<{
1415
setProductionLevel: (level: number) => void;
1516
}>({
1617
protectionLevel: 1,
17-
setProductionLevel: () => {
18-
throw 'Not implemented';
19-
},
18+
setProductionLevel: NotImplementCallback,
2019
});
2120

2221
export function useDatabaseSetting() {

src/renderer/contexts/DialogProvider.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import NotImplementCallback from 'libs/NotImplementCallback';
12
import {
23
createContext,
34
useContext,
@@ -10,9 +11,7 @@ import Modal from 'renderer/components/Modal';
1011
const DialogContext = createContext<{
1112
showErrorDialog: (message: string) => void;
1213
}>({
13-
showErrorDialog: () => {
14-
throw 'Not implemented';
15-
},
14+
showErrorDialog: NotImplementCallback,
1615
});
1716

1817
export function useDialog() {

src/renderer/contexts/QueryResultChangeProvider.tsx

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import NotImplementCallback from 'libs/NotImplementCallback';
12
import ResultChangeCollector from 'libs/ResultChangeCollector';
23
import {
34
createContext,
@@ -14,15 +15,9 @@ const QueryResultChangeContext = createContext<{
1415
clearChange: () => void;
1516
}>({
1617
collector: new ResultChangeCollector(),
17-
setChange: () => {
18-
throw 'Not implemented';
19-
},
20-
removeChange: () => {
21-
throw 'Not implemented';
22-
},
23-
clearChange: () => {
24-
throw 'Not implemented';
25-
},
18+
setChange: NotImplementCallback,
19+
removeChange: NotImplementCallback,
20+
clearChange: NotImplementCallback,
2621
});
2722

2823
export function useQueryResultChange() {

src/renderer/contexts/SqlExecuteProvider.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,13 @@ import SQLCommonInterface from 'drivers/base/SQLCommonInterface';
55
import { PropsWithChildren, createContext, useContext, useMemo } from 'react';
66
import { useDatabaseSetting } from './DatabaseSettingProvider';
77
import { SqlRunnerManager } from 'libs/SqlRunnerManager';
8+
import NotImplementCallback from 'libs/NotImplementCallback';
89

910
const SqlExecuteContext = createContext<{
1011
runner: SqlRunnerManager;
1112
common: SQLCommonInterface;
1213
}>({
13-
runner: new SqlRunnerManager(() => {
14-
throw 'Not implemented';
15-
}),
14+
runner: new SqlRunnerManager(NotImplementCallback),
1615
common: new NotImplementCommonInterface(),
1716
});
1817

0 commit comments

Comments
 (0)