Skip to content

Commit 02796e2

Browse files
authored
Merge pull request #375 from jlewis91/remove-old-tests
Remove commented out tests
2 parents 28fbbad + 039e61a commit 02796e2

File tree

2 files changed

+0
-65
lines changed

2 files changed

+0
-65
lines changed

test/test_base.jl

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -20,50 +20,8 @@ renderer(:canvas)
2020
actionlinks(false)
2121
@test actionlinks() == false
2222

23-
###
2423
ts = collect(range(0, stop=2, length=100))
2524
rs = Float64[ rand() * 0.1 + cos(x) for x in ts]
2625
datvals = [ Dict(:time => t, :res => r) for (t, r) in zip(ts, rs) ]
2726

28-
# @test isa(vlconfig(background="green"), VegaLite.VLSpec{:config})
29-
# @test isa(markline(), VegaLite.VLSpec{:mark})
30-
# @test isa(vldata(values=datvals), VegaLite.VLSpec{:data})
31-
# @test isa(VegaLite.data(values=datvals), VegaLite.VLSpec{:data})
32-
# @test equiv(VegaLite.data(values=datvals), vldata(values=datvals))
33-
34-
35-
# vs = encoding(xquantitative(field=:x, vlbin(maxbins=20),
36-
# vlaxis(title="values")),
37-
# yquantitative(field=:*, aggregate=:count))
38-
39-
# @test length(Vega.getparams(vs)) == 2
40-
# @test haskey(Vega.getparams(vs), "x")
41-
# @test haskey(Vega.getparams(vs), "y")
42-
# @test length(Vega.getparams(vs)["x"]) == 4
43-
# @test get(Vega.getparams(vs)["x"], "axis", "") == Dict("title"=>"values")
44-
# @test get(Vega.getparams(vs)["x"], "field", "") == :x
45-
# @test get(Vega.getparams(vs)["x"], "type", "") == "quantitative"
46-
# @test get(Vega.getparams(vs)["x"], "bin", "") == Dict("maxbins" => 20)
47-
# @test length(Vega.getparams(vs)["y"]) == 3
48-
# @test get(Vega.getparams(vs)["y"], "aggregate", "") == :count
49-
# @test get(Vega.getparams(vs)["y"], "field", "") == :*
50-
# @test get(Vega.getparams(vs)["y"], "type", "") == "quantitative"
51-
52-
53-
# vs2 = xquantitative(field=:x, vlbin(maxbins=20),
54-
# vlaxis(title="values")) |>
55-
# yquantitative(field=:*, aggregate=:count) ;
56-
# vs2 = encoding(vs2) ;
57-
# @test equiv(vs, vs2)
58-
59-
60-
###
61-
# using VegaDatasets
62-
63-
# cars = dataset("cars")
64-
65-
# @test isa(VegaLite.data(cars), VegaLite.VLSpec{:data})
66-
# @test equiv(VegaLite.data(cars) |> plot(width=200),
67-
# cars |> plot(width=200))
68-
6927
end

test/test_io.jl

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ vlp = getvlplot()
1313

1414
@testset "$fmt (indent=$(repr(indent)))" for (fmt, plt) in [
1515
(format"vegalite", vlp)
16-
# (format"vega", vgp) # waiting for FileIO
1716
],
1817
indent in [nothing, 4]
1918

@@ -43,9 +42,6 @@ Base.Filesystem.mktempdir() do folder
4342
VegaLite.png(joinpath(folder, "test1.png"), p)
4443
@test isfile(joinpath(folder, "test1.png"))
4544

46-
# VegaLite.eps(joinpath(folder,"test1.eps"), p)
47-
# @test isfile(joinpath(folder,"test1.eps"))
48-
4945
VegaLite.savefig(joinpath(folder, "test2.svg"), p)
5046
@test isfile(joinpath(folder, "test2.svg"))
5147

@@ -55,9 +51,6 @@ Base.Filesystem.mktempdir() do folder
5551
VegaLite.savefig(joinpath(folder, "test2.png"), p)
5652
@test isfile(joinpath(folder, "test2.png"))
5753

58-
# VegaLite.savefig(joinpath(folder,"test2.eps"), p)
59-
# @test isfile(joinpath(folder,"test2.eps"))
60-
6154
save(joinpath(folder, "test3.svg"), p)
6255
@test isfile(joinpath(folder, "test3.svg"))
6356

@@ -67,9 +60,6 @@ Base.Filesystem.mktempdir() do folder
6760
save(joinpath(folder, "test3.png"), p)
6861
@test isfile(joinpath(folder, "test3.png"))
6962

70-
# save(joinpath(folder,"test2.eps"), p)
71-
# @test isfile(joinpath(folder,"test2.eps"))
72-
7363
save(joinpath(folder, "test4.svg"), vgp)
7464
@test isfile(joinpath(folder, "test4.svg"))
7565

@@ -79,9 +69,6 @@ Base.Filesystem.mktempdir() do folder
7969
save(joinpath(folder, "test4.png"), vgp)
8070
@test isfile(joinpath(folder, "test4.png"))
8171

82-
# save(joinpath(folder,"test4.eps"), vgp)
83-
# @test isfile(joinpath(folder,"test4.eps"))
84-
8572
Vega.savespec(joinpath(folder, "test1.vegalite"), p)
8673
@test isfile(joinpath(folder, "test1.vegalite"))
8774

@@ -106,16 +93,6 @@ Base.Filesystem.mktempdir() do folder
10693

10794
@test_broken p |> save("testfile.png")
10895

109-
# TODO Enable once FileIO stuff is merged
110-
# save(joinpath(folder,"test3.vega"), vgpl1)
111-
# @test isfile(joinpath(folder,"test3.vega"))
112-
113-
# vgpl3 = load(joinpath(folder,"test3.vega"))
114-
# @test isa(vgpl2, Vega.VGSpec)
115-
116-
# save(joinpath(folder,"test4.vega"), vgpl1, include_data=true)
117-
# @test isfile(joinpath(folder,"test4.vega"))
118-
11996
end
12097

12198
end

0 commit comments

Comments
 (0)