Merge pull request #434 from queryverse:buffered-output

Use a buffered output stream

Author: davidanthoff

Project.toml

@@ -3,6 +3,7 @@ uuid = "112f6efa-9a02-5b7d-90c0-432ed331239a"
 version = "3.2.1-DEV"
 
 [deps]
+BufferedStreams = "e1450e63-4bb3-523b-b2a4-4ffa8c0fd77d"
 Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 TableTraits = "3783bdb8-4a98-5b6b-af9a-565f29a5fe9c"
@@ -30,6 +31,7 @@ DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
 Setfield = "efcf1570-3423-57d1-acb7-fd33fddbac46"
 
 [compat]
+BufferedStreams = "1.1"
 TableTraits = "0.3.1, 0.4, 1"
 IteratorInterfaceExtensions = "0.1.1, 1"
 JSON = "0.19, 0.20, 0.21"

src/VegaLite.jl

@@ -21,6 +21,7 @@ using DataStructures
 import TableTraitsUtils
 using Vega
 import Base64
+import BufferedStreams
 
 export renderer, actionlinks
 export @vl_str, @vlplot, vlplot, @vlfrag, vlfrag

src/rendering/show.jl

@@ -2,13 +2,21 @@ function convert_vl_to_x(v::VLSpec, fileformat; cmd_args="")
     script_path = vegalite_app_path("node_modules", "vega-lite", "bin", "vl2$fileformat")
 
     p = open(Cmd(`$(NodeJS_18_jll.node()) $script_path $cmd_args`, dir=vegalite_app_path()),"r+")
+
+    buffered_output_stream = BufferedStreams.BufferedOutputStream(p.in)
+
     writer = @async begin
-        our_json_print(p, v)
+        our_json_print(buffered_output_stream, v)
+        close(buffered_output_stream)
         close(p.in)
     end
+
     reader = @async read(p, String)
-    wait(p)
+
+    wait(writer)    
+    wait(p)   
     res = fetch(reader)
+    
     if p.exitcode != 0
         throw(ArgumentError("Invalid spec"))
     end