Skip to content

Commit 9149ae9

Browse files
authored
Merge pull request #432 from queryverse:ppi-png
Add support for ppi setting for png export
2 parents 7268bc4 + 6174395 commit 9149ae9

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/rendering/show.jl

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
function convert_vl_to_x(v::VLSpec, fileformat)
1+
function convert_vl_to_x(v::VLSpec, fileformat; cmd_args="")
22
script_path = vegalite_app_path("node_modules", "vega-lite", "bin", "vl2$fileformat")
33

4-
p = open(Cmd(`$(NodeJS_18_jll.node()) $script_path`, dir=vegalite_app_path()),"r+")
4+
p = open(Cmd(`$(NodeJS_18_jll.node()) $script_path $cmd_args`, dir=vegalite_app_path()),"r+")
55
writer = @async begin
66
our_json_print(p, v)
77
close(p.in)
@@ -66,7 +66,11 @@ end
6666

6767
function Base.show(io::IO, m::MIME"image/png", v::VLSpec)
6868
if vegaliate_app_includes_canvas[]
69-
print(io, convert_vl_to_x(v, "png"))
69+
if haskey(io, :ppi)
70+
print(io, convert_vl_to_x(v, "png", cmd_args="--ppi=$(io[:ppi])"))
71+
else
72+
print(io, convert_vl_to_x(v, "png"))
73+
end
7074
else
7175
error("Not yet implemented.")
7276
# svgstring = convert_vl_to_svg(v)

0 commit comments

Comments
 (0)