api!: Improved noexcept and const correctness.

Author: amunra

include/questdb/ilp/line_sender.h

@@ -174,7 +174,7 @@ line_sender* line_sender_connect(
  * @return true if an error occured with a sender and it must be closed.
  */
 LINESENDER_API
-bool line_sender_must_close(line_sender* sender);
+bool line_sender_must_close(const line_sender* sender);
 
 /**
  * Close the connection. Does not flush. Non-idempotent.
@@ -318,7 +318,7 @@ bool line_sender_at_now(
  * @return Accumulated batch size.
  */
 LINESENDER_API
-size_t line_sender_pending_size(line_sender* sender);
+size_t line_sender_pending_size(const line_sender* sender);
 
 /**
  * Send batch-up rows messages to the QuestDB server.

include/questdb/ilp/line_sender.hpp

@@ -70,7 +70,7 @@ namespace questdb::ilp
         {}
 
         /** Error code categorising the error. */
-        line_sender_error_code code() const { return _code; }
+        line_sender_error_code code() const noexcept { return _code; }
 
     private:
         inline static line_sender_error from_c(::line_sender_error* c_err)
@@ -120,8 +120,8 @@ namespace questdb::ilp
             : utf8_view{s_view.data(), s_view.size()}
         {}
 
-        size_t size() const { return _impl.len; }
-        const char* data() const { return _impl.buf; }
+        size_t size() const noexcept { return _impl.len; }
+        const char* data() const noexcept { return _impl.buf; }
 
     private:
         ::line_sender_utf8 _impl;
@@ -147,8 +147,8 @@ namespace questdb::ilp
             : name_view{s_view.data(), s_view.size()}
         {}
 
-        size_t size() const { return _impl.len; }
-        const char* data() const { return _impl.buf; }
+        size_t size() const noexcept { return _impl.len; }
+        const char* data() const noexcept { return _impl.buf; }
 
     private:
         ::line_sender_name _impl;
@@ -235,14 +235,14 @@ namespace questdb::ilp
                     net_interface}
         {}
 
-        line_sender(line_sender&& other)
+        line_sender(line_sender&& other) noexcept
             : _impl{other._impl}
         {
             if (this != &other)
                 other._impl = nullptr;
         }
 
-        line_sender& operator=(line_sender&& other)
+        line_sender& operator=(line_sender&& other) noexcept
         {
             if (this != &other)
             {
@@ -384,7 +384,7 @@ namespace questdb::ilp
          *
          * @return Accumulated batch size.
          */
-        size_t pending_size()
+        size_t pending_size() const noexcept
         {
             return _impl
                 ? ::line_sender_pending_size(_impl)
@@ -408,7 +408,7 @@ namespace questdb::ilp
          * Check if an error occured previously and the sender must be closed.
          * @return true if an error occured with a sender and it must be closed.
          */
-        bool must_close() noexcept
+        bool must_close() const noexcept
         {
             return _impl
                 ? ::line_sender_must_close(_impl)

src/line_sender.c

@@ -927,7 +927,7 @@ bool line_sender_at_now(
     return true;
 }
 
-size_t line_sender_pending_size(line_sender* sender)
+size_t line_sender_pending_size(const line_sender* sender)
 {
     return (sender->state != line_sender_state_moribund)
         ? mem_writer_len(&sender->writer)
@@ -988,7 +988,7 @@ bool line_sender_flush(
     return true;
 }
 
-bool line_sender_must_close(line_sender* sender)
+bool line_sender_must_close(const line_sender* sender)
 {
     return sender->state == line_sender_state_moribund;
 }

src/mem_writer.c

@@ -44,12 +44,12 @@ void mem_writer_open(mem_writer* writer, size_t capacity)
     writer->end = writer->head + capacity;
 }
 
-size_t mem_writer_len(mem_writer* writer)
+size_t mem_writer_len(const mem_writer* writer)
 {
     return (size_t)(writer->tail - writer->head);
 }
 
-const char* mem_writer_peek(mem_writer* writer, size_t* len_out)
+const char* mem_writer_peek(const mem_writer* writer, size_t* len_out)
 {
     *len_out = mem_writer_len(writer);
     return writer->head;

src/mem_writer.h

@@ -36,9 +36,9 @@ typedef struct mem_writer {
 
 void mem_writer_open(mem_writer* writer, size_t capacity);
 
-size_t mem_writer_len(mem_writer* writer);
+size_t mem_writer_len(const mem_writer* writer);
 
-const char* mem_writer_peek(mem_writer* writer, size_t* len_out);
+const char* mem_writer_peek(const mem_writer* writer, size_t* len_out);
 
 char* mem_writer_steal_and_close(mem_writer* writer, size_t* len_out);