Skip to content

Commit 6d25e29

Browse files
committed
update staticcheck command and fix staticcheck code.
1 parent b4669b2 commit 6d25e29

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,8 @@ jobs:
2424
- name: Run vet
2525
run: go vet ./...
2626

27-
- name: Run staticcheck
28-
uses: dominikh/[email protected]
29-
with:
30-
version: "2023.1.2"
31-
install-go: false
32-
cache-key: ${{ matrix.go-version }}
27+
- name: Run Staticcheck
28+
run: go run honnef.co/go/tools/cmd/staticcheck@latest ./...
3329

3430
- name: Run tests
3531
run: go test -v ./...

buffer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ type arrayElemType byte
8686

8787
const (
8888
arrayElemDouble arrayElemType = 10
89-
arrayElemNull = 33
89+
arrayElemNull arrayElemType = 33
9090
)
9191

9292
// buffer is a wrapper on top of bytes.Buffer. It extends the

http_sender_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -777,6 +777,7 @@ func TestAutoDetectProtocolVersionOldServer1(t *testing.T) {
777777
defer srv.Close()
778778
sender, err := qdb.NewLineSender(ctx, qdb.WithHttp(), qdb.WithAddress(srv.Addr()))
779779
assert.Equal(t, qdb.ProtocolVersion(sender), qdb.ProtocolVersion1)
780+
assert.NoError(t, err)
780781
}
781782

782783
func TestAutoDetectProtocolVersionOldServer2(t *testing.T) {
@@ -787,6 +788,7 @@ func TestAutoDetectProtocolVersionOldServer2(t *testing.T) {
787788
defer srv.Close()
788789
sender, err := qdb.NewLineSender(ctx, qdb.WithHttp(), qdb.WithAddress(srv.Addr()))
789790
assert.Equal(t, qdb.ProtocolVersion(sender), qdb.ProtocolVersion1)
791+
assert.NoError(t, err)
790792
}
791793

792794
func TestAutoDetectProtocolVersionOldServer3(t *testing.T) {
@@ -797,6 +799,7 @@ func TestAutoDetectProtocolVersionOldServer3(t *testing.T) {
797799
defer srv.Close()
798800
sender, err := qdb.NewLineSender(ctx, qdb.WithHttp(), qdb.WithAddress(srv.Addr()))
799801
assert.Equal(t, qdb.ProtocolVersion(sender), qdb.ProtocolVersion1)
802+
assert.NoError(t, err)
800803
}
801804

802805
func TestAutoDetectProtocolVersionNewServer1(t *testing.T) {
@@ -807,6 +810,7 @@ func TestAutoDetectProtocolVersionNewServer1(t *testing.T) {
807810
defer srv.Close()
808811
sender, err := qdb.NewLineSender(ctx, qdb.WithHttp(), qdb.WithAddress(srv.Addr()))
809812
assert.Equal(t, qdb.ProtocolVersion(sender), qdb.ProtocolVersion2)
813+
assert.NoError(t, err)
810814
}
811815

812816
func TestAutoDetectProtocolVersionNewServer2(t *testing.T) {
@@ -817,6 +821,7 @@ func TestAutoDetectProtocolVersionNewServer2(t *testing.T) {
817821
defer srv.Close()
818822
sender, err := qdb.NewLineSender(ctx, qdb.WithHttp(), qdb.WithAddress(srv.Addr()))
819823
assert.Equal(t, qdb.ProtocolVersion(sender), qdb.ProtocolVersion2)
824+
assert.NoError(t, err)
820825
}
821826

822827
func TestAutoDetectProtocolVersionNewServer3(t *testing.T) {
@@ -827,6 +832,7 @@ func TestAutoDetectProtocolVersionNewServer3(t *testing.T) {
827832
defer srv.Close()
828833
sender, err := qdb.NewLineSender(ctx, qdb.WithHttp(), qdb.WithAddress(srv.Addr()))
829834
assert.Equal(t, qdb.ProtocolVersion(sender), qdb.ProtocolVersion2)
835+
assert.NoError(t, err)
830836
}
831837

832838
func TestAutoDetectProtocolVersionNewServer4(t *testing.T) {
@@ -857,6 +863,7 @@ func TestSpecifyProtocolVersion(t *testing.T) {
857863
defer srv.Close()
858864
sender, err := qdb.NewLineSender(ctx, qdb.WithHttp(), qdb.WithAddress(srv.Addr()), qdb.WithProtocolVersion(qdb.ProtocolVersion1))
859865
assert.Equal(t, qdb.ProtocolVersion(sender), qdb.ProtocolVersion1)
866+
assert.NoError(t, err)
860867
}
861868

862869
func TestArrayColumnUnsupportedInHttpProtocolV1(t *testing.T) {

0 commit comments

Comments
 (0)