code reviews.

Author: kafka1991

buffer.go

@@ -647,8 +647,8 @@ func (b *buffer) Float64Array2DColumn(name string, values [][]float64) *buffer {
 	var dim2 int
 	if dim1 > 0 {
 		dim2 = len(values[0])
-		totalElements := dim1 * dim2
-		if dim1 > MaxArrayElements || dim2 > MaxArrayElements || totalElements > MaxArrayElements || totalElements < 0 {
+		totalElements := product([]uint{uint(dim1), uint(dim2)})
+		if totalElements > MaxArrayElements {
 			b.lastErr = fmt.Errorf("array size %d exceeds maximum limit %d", totalElements, MaxArrayElements)
 			return b
 		}
@@ -699,8 +699,8 @@ func (b *buffer) Float64Array3DColumn(name string, values [][][]float64) *buffer
 		if dim2 > 0 {
 			dim3 = len(values[0][0])
 		}
-		totalElements := dim1 * dim2 * dim3
-		if dim1 > MaxArrayElements || dim2 > MaxArrayElements || dim3 > MaxArrayElements || totalElements > MaxArrayElements || totalElements < 0 {
+		totalElements := product([]uint{uint(dim1), uint(dim2), uint(dim3)})
+		if totalElements > MaxArrayElements {
 			b.lastErr = fmt.Errorf("array size %d exceeds maximum limit %d", totalElements, MaxArrayElements)
 			return b
 		}

integration_test.go

@@ -27,6 +27,7 @@ package questdb_test
 import (
 	"context"
 	"fmt"
+	"math"
 	"math/big"
 	"path/filepath"
 	"reflect"
@@ -417,11 +418,12 @@ func (suite *integrationTestSuite) TestE2EValidWrites() {
 			"double array",
 			testTable,
 			func(s qdb.LineSender) error {
-				values1D := []float64{1.0, 2.0, 3.0, 4.0, 5.0}
-				values2D := [][]float64{{1.0, 2.0}, {3.0, 4.0}, {5.0, 6.0}}
-				values3D := [][][]float64{{{1.0, 2.0}, {3.0, 4.0}}, {{5.0, 6.0}, {7.0, 8.0}}}
+				values1D := []float64{1.0, 2.0, 3.0, 4.0, 5.0, math.NaN()}
+				values2D := [][]float64{{1.0, 2.0}, {3.0, 4.0}, {5.0, 6.0}, {math.NaN(), math.NaN()}}
+				values3D := [][][]float64{{{1.0, 2.0}, {3.0, 4.0}}, {{5.0, 6.0}, {7.0, math.NaN()}}}
 				arrayND, _ := qdb.NewNDArray[float64](2, 2, 1, 2)
 				arrayND.Fill(11.0)
+				arrayND.Set(math.NaN(), 1, 1, 0, 1)
 
 				err := s.
 					Table(testTable).
@@ -464,10 +466,10 @@ func (suite *integrationTestSuite) TestE2EValidWrites() {
 				},
 				Dataset: [][]interface{}{
 					{
-						[]interface{}{float64(1), float64(2), float64(3), float64(4), float64(5)},
-						[]interface{}{[]interface{}{float64(1), float64(2)}, []interface{}{float64(3), float64(4)}, []interface{}{float64(5), float64(6)}},
-						[]interface{}{[]interface{}{[]interface{}{float64(1), float64(2)}, []interface{}{float64(3), float64(4)}}, []interface{}{[]interface{}{float64(5), float64(6)}, []interface{}{float64(7), float64(8)}}},
-						[]interface{}{[]interface{}{[]interface{}{[]interface{}{float64(11), float64(11)}}, []interface{}{[]interface{}{float64(11), float64(11)}}}, []interface{}{[]interface{}{[]interface{}{float64(11), float64(11)}}, []interface{}{[]interface{}{float64(11), float64(11)}}}},
+						[]interface{}{float64(1), float64(2), float64(3), float64(4), float64(5), nil},
+						[]interface{}{[]interface{}{float64(1), float64(2)}, []interface{}{float64(3), float64(4)}, []interface{}{float64(5), float64(6)}, []interface{}{nil, nil}},
+						[]interface{}{[]interface{}{[]interface{}{float64(1), float64(2)}, []interface{}{float64(3), float64(4)}}, []interface{}{[]interface{}{float64(5), float64(6)}, []interface{}{float64(7), nil}}},
+						[]interface{}{[]interface{}{[]interface{}{[]interface{}{float64(11), float64(11)}}, []interface{}{[]interface{}{float64(11), float64(11)}}}, []interface{}{[]interface{}{[]interface{}{float64(11), float64(11)}}, []interface{}{[]interface{}{float64(11), nil}}}},
 						"1970-01-01T00:00:00.000001Z"},
 					{
 						[]interface{}{},

ndarray.go

@@ -208,10 +208,13 @@ func validateShape(shape []uint) error {
 
 func product(s []uint) uint {
 	if len(s) == 0 {
-		return 0
+		return 1
 	}
 	p := uint(1)
 	for _, v := range s {
+		if v != 0 && p > MaxArrayElements/v {
+			return MaxArrayElements + 1
+		}
 		p *= v
 	}
 	return p

ndarray_test.go

@@ -178,7 +178,8 @@ func TestReshape_InvalidShapes(t *testing.T) {
 	}{
 		{"wrong size", []uint{5}},
 		{"empty shape", []uint{}},
-		{"too large", []uint{qdb.MaxArrayElements + 1}},
+		{"too large1", []uint{qdb.MaxArrayElements + 1}},
+		{"too large2", []uint{4294967296, 4294967296}},
 	}
 
 	for _, tc := range testCases {