Delete unnecessary code in tests

delete_directory_recursive, called by test fixture cleanup code, will
delete directories even if permissions disallow traversal. This means
manually chmod-ing these directories in the test is unnecessary. Delete
the redundant chmod calls.

This commit should not reduce test coverage.

Author: strager

test/test-file-canonical.cpp

@@ -846,10 +846,6 @@ TEST_F(test_file_canonical, unsearchable_parent_directory) {
   EXPECT_THAT(canonical.error().canonicalizing_path,
               ::testing::EndsWith("dir/file"));
   EXPECT_EQ(canonical.error().io_error.error, EACCES);
-
-  // Allow test cleanup to delete the directory.
-  EXPECT_EQ(::chmod((temp_dir + "/dir").c_str(), 0700), 0)
-      << std::strerror(errno);
 }
 
 TEST_F(test_file_canonical, unsearchable_grandparent_directory) {
@@ -872,10 +868,6 @@ TEST_F(test_file_canonical, unsearchable_grandparent_directory) {
   EXPECT_THAT(canonical.error().canonicalizing_path,
               ::testing::EndsWith("dir/subdir"));
   EXPECT_EQ(canonical.error().io_error.error, EACCES);
-
-  // Allow test cleanup to delete the directory.
-  EXPECT_EQ(::chmod((temp_dir + "/dir").c_str(), 0700), 0)
-      << std::strerror(errno);
 }
 #endif