wasm: refactor preparing for Process reuse

Each DocumentLinter creates and manages its own Process (WebAssembly
memory space). I want DocumentLinter-s to share a single Process.

Refactor DocumentLinter to take a DocumentProcessManager which will, in
the future, store the single Process.

This commit should not change behavior.

Author: strager

plugin/vscode/extension.js

@@ -7,12 +7,9 @@ let vscode = require("vscode");
 let {
   DiagnosticSeverity,
   DocumentLinter,
-  createProcessFactoryAsync,
+  DocumentProcessManager,
 } = require("quick-lint-js-wasm/quick-lint-js.js");
 
-// TODO(strager): Allow developers to reload the .wasm file.
-let processFactoryPromise = createProcessFactoryAsync();
-
 class VSCodeDocumentLinter {
   constructor(document, diagnosticCollection) {
     this._documentLinter = new DocumentLinter(
@@ -30,7 +27,7 @@ class VSCodeDocumentLinter {
           diagnosticCollection.delete(document.uri);
         },
       },
-      processFactoryPromise
+      new DocumentProcessManager()
     );
   }
 

wasm/quick-lint-js.js

@@ -47,9 +47,9 @@ class DocumentLinter {
   //   getText(): string;
   //   setDiagnostics(diagnostics: Object[]): void;
   //   removeDiagnostics(): void;
-  constructor(document, processFactoryPromise) {
+  constructor(document, documentProcessManager) {
     this._document = document;
-    this._processFactoryPromise = processFactoryPromise;
+    this._documentProcessManager = documentProcessManager;
     this._state = DocumentLinterState.NO_PARSER;
 
     // Used only in states: CREATING_PARSER
@@ -69,7 +69,7 @@ class DocumentLinter {
     assertEqual(this._state, DocumentLinterState.NO_PARSER);
     this._state = DocumentLinterState.CREATING_PARSER;
     this._parserPromise = (async () => {
-      let factory = await this._processFactoryPromise;
+      let factory = await this._documentProcessManager._processFactoryPromise;
       // TODO(strager): Reuse processes across documents.
       let process = await factory.createProcessAsync();
       let parser = await process.createDocumentForVSCodeAsync();
@@ -252,7 +252,7 @@ class DocumentLinter {
       let diags;
       try {
         // TODO(strager): Reuse processes across documents.
-        let factory = await this._processFactoryPromise;
+        let factory = await this._documentProcessManager._processFactoryPromise;
         let process = await factory.createProcessAsync();
         let parser = await process.createDocumentForVSCodeAsync();
 
@@ -289,6 +289,14 @@ class DocumentLinter {
 }
 exports.DocumentLinter = DocumentLinter;
 
+class DocumentProcessManager {
+  constructor() {
+    // TODO(strager): Allow developers to reload the .wasm file.
+    this._processFactoryPromise = createProcessFactoryAsync();
+  }
+}
+exports.DocumentProcessManager = DocumentProcessManager;
+
 async function createProcessFactoryAsync() {
   if (typeof window === "undefined") {
     // Node.js.

wasm/test-document.js

@@ -10,13 +10,12 @@ let {
   DiagnosticSeverity,
   DocumentLinter,
   DocumentLinterDisposed,
+  DocumentProcessManager,
   LintingCrashed,
   ProcessCrashed,
   createProcessFactoryAsync,
 } = qljs;
 
-let processFactoryPromise = createProcessFactoryAsync();
-
 describe("DocumentLinter", () => {
   let toDisposeAfterTest = [];
   function disposeAfterTest(disposable) {
@@ -38,7 +37,7 @@ describe("DocumentLinter", () => {
   it("diagnostic severity", async () => {
     let document = new MockDocument("let x;let x;\nundeclaredVariable");
     let linter = disposeAfterTest(
-      new DocumentLinter(document, processFactoryPromise)
+      new DocumentLinter(document, new DocumentProcessManager())
     );
     await linter.editorChangedVisibilityAsync();
 
@@ -63,7 +62,7 @@ describe("DocumentLinter", () => {
   it("opening editor lints", async () => {
     let document = new MockDocument("let x;let x;");
     let linter = disposeAfterTest(
-      new DocumentLinter(document, processFactoryPromise)
+      new DocumentLinter(document, new DocumentProcessManager())
     );
 
     await linter.editorChangedVisibilityAsync();
@@ -76,7 +75,7 @@ describe("DocumentLinter", () => {
   it("applying change to unopened editor lints", async () => {
     let document = new MockDocument("let x;");
     let linter = disposeAfterTest(
-      new DocumentLinter(document, processFactoryPromise)
+      new DocumentLinter(document, new DocumentProcessManager())
     );
     assert.deepStrictEqual(document.diagnostics, []);
 
@@ -104,7 +103,7 @@ describe("DocumentLinter", () => {
 
     let document = new MockDocument("let x;");
     let linter = disposeAfterTest(
-      new DocumentLinter(document, processFactoryPromise)
+      new DocumentLinter(document, new DocumentProcessManager())
     );
     await linter.editorChangedVisibilityAsync();
     assert.deepStrictEqual(document.diagnostics, []);
@@ -133,14 +132,14 @@ describe("DocumentLinter", () => {
 
   it("dispose unused linter", async () => {
     let document = new MockDocument("let x;");
-    let linter = new DocumentLinter(document, processFactoryPromise);
+    let linter = new DocumentLinter(document, new DocumentProcessManager());
     // Should not throw.
     await linter.disposeAsync();
   });
 
   it("dispose initializing linter", async () => {
     let document = new MockDocument("hello.js", "let x;");
-    let linter = new DocumentLinter(document, processFactoryPromise);
+    let linter = new DocumentLinter(document, new DocumentProcessManager());
     let promise = linter.editorChangedVisibilityAsync();
 
     // Should not throw.
@@ -151,7 +150,7 @@ describe("DocumentLinter", () => {
   it("concurrent edits are applied in order of calls", async () => {
     let document = new MockDocument("let x;");
     let linter = disposeAfterTest(
-      new DocumentLinter(document, processFactoryPromise)
+      new DocumentLinter(document, new DocumentProcessManager())
     );
     await linter.editorChangedVisibilityAsync();
 
@@ -223,7 +222,7 @@ describe("DocumentLinter", () => {
       let linter = null;
       try {
         let document = new MockDocument("let x;let x;\n");
-        linter = new DocumentLinter(document, processFactoryPromise);
+        linter = new DocumentLinter(document, new DocumentProcessManager());
 
         let crashedOpeningEditor = await didLintingCrashAsync(async () => {
           await linter.editorChangedVisibilityAsync();
@@ -304,7 +303,7 @@ describe("DocumentLinter", () => {
       let linter;
       try {
         let document = new MockDocument("const x = 10;");
-        linter = new DocumentLinter(document, processFactoryPromise);
+        linter = new DocumentLinter(document, new DocumentProcessManager());
         let shouldOpenEditorBeforeChanges = rng.nextCoinFlip();
         if (shouldOpenEditorBeforeChanges) {
           await linter.editorChangedVisibilityAsync();