Skip to content

Commit 0841135

Browse files
committed
benchmark-lsp: rneame TypeScript-Theia -> TypeScript
It looks like TypeScript's LSP server migrated from https://github.com/theia-ide/typescript-language-server to https://github.com/typescript-language-server/typescript-language-server, dropping the Theia branding. Remove our mention of Theia internally and on the website's benchmark results.
1 parent 12f1586 commit 0841135

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

benchmark/benchmark-lsp/LSPBenchmark.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@ initializeLSP initializationOptions = do
130130
-- Flow's LSP server requires rootURI.
131131
let rootURI = LSP.filePathToUri rootPath
132132
let workspaceFolders = [LSP.WorkspaceFolder (LSP.getUri rootURI) "benchmarks"]
133-
-- PublishDiagnosticsClientCapabilities is required by the TypeScript-Theia
134-
-- LSP server since version 0.6.0:
133+
-- PublishDiagnosticsClientCapabilities is required by the TypeScript LSP
134+
-- server since version 0.6.0:
135135
-- https://github.com/typescript-language-server/typescript-language-server/pull/229
136136
let textDocumentClientCapabilities =
137137
def {LSP._publishDiagnostics = Just (LSP.PublishDiagnosticsClientCapabilities Nothing Nothing Nothing)}

benchmark/benchmark-lsp/Main.hs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -326,9 +326,9 @@ waitForOneDiagnosticsMessageOrTimeout timeoutMicroseconds = do
326326
Nothing -> return Nothing
327327
_ -> fail "Unimplemented message"
328328

329-
-- | HACK(strager): Some LSP servers, such as Flow and TypeScript-Theia, give us
330-
-- an empty list of diagnostics before giving us the real list of diagnostics.
331-
-- Skip the empty list and wait for the real list.
329+
-- | HACK(strager): Some LSP servers, such as Flow and TypeScript, give us an
330+
-- empty list of diagnostics before giving us the real list of diagnostics. Skip
331+
-- the empty list and wait for the real list.
332332
waitUntilSomeDiagnosticsWithTimeout :: Int -> LSPM [LSP.Diagnostic]
333333
waitUntilSomeDiagnosticsWithTimeout timeoutMicroseconds =
334334
fix $ \loop ->

benchmark/benchmark-lsp/benchmark-config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"allowIncrementalChanges": false
6161
},
6262
{
63-
"name": "TypeScript-Theia",
63+
"name": "TypeScript",
6464
"command": ["node", "./node_modules/.bin/typescript-language-server", "--stdio"],
6565
"cwd": "typescript/",
6666
"needFilesOnDisk": true

website/public/benchmarks/criterion-json-to-html.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ class Series {
159159
RSLint: 120.0,
160160
Flow: 180.0,
161161
Deno: 240.0,
162-
"TypeScript-Theia": 300.0,
162+
TypeScript: 300.0,
163163
};
164164
return hues[this.name];
165165
}

website/public/benchmarks/index.ejs.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ <h2>Methodology</h2>
120120
</li>
121121
<li>
122122
<strong class="linter-name" style="--hue: 300">TypeScript</strong>
123-
version 4.2.4 (with Theia's language server version 0.5.1 and Node
124-
version v16.0.0)
123+
version 4.2.4 (with language server version 0.5.1 and Node version
124+
v16.0.0)
125125
</li>
126126
</ul>
127127

website/public/benchmarks/open-wait-close-express-router-js.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)