Skip to content

Commit 0db79c9

Browse files
committed
Mention GitHub issues in TODO comments
1 parent b2ee5cb commit 0db79c9

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

test/test-lex.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ TEST_F(test_lex, fail_lex_legacy_octal_numbers) {
352352
});
353353
}
354354

355-
// TODO (👮🏾‍♀️) (when strict mode implemented) legacy octal number
355+
// TODO (#73) (when strict mode implemented) legacy octal number
356356
// literal tests to fail in strict mode
357357

358358
TEST_F(test_lex, legacy_octal_numbers_cannot_contain_underscores) {
@@ -1050,7 +1050,7 @@ TEST_F(test_lex, lex_regular_expression_literals) {
10501050

10511051
// TODO(#187): Report invalid escape sequences.
10521052

1053-
// TODO(strager): Report invalid characters and mismatched brackets.
1053+
// TODO(#203): Report invalid characters and mismatched brackets.
10541054
}
10551055

10561056
TEST_F(test_lex, lex_regular_expression_literal_with_digit_flag) {

test/test-lint.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2536,7 +2536,7 @@ TEST(test_lint_magic_arguments, catch_variable_shadows_magic_arguments) {
25362536
EXPECT_THAT(v.errors, IsEmpty());
25372537
}
25382538

2539-
// TODO(strager): 'arguments' should not be declared in arrow functions.
2539+
// TODO(#204): 'arguments' should not be declared in arrow functions.
25402540

25412541
TEST(test_lint_typeof, using_undeclared_variable_in_typeof_is_not_an_error) {
25422542
const char8 use[] = u8"v";

test/test-lsp-error-reporter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ TEST_F(test_lsp_error_reporter, assignment_before_variable_declaration) {
8585
"variable assigned before its declaration");
8686
EXPECT_EQ(diagnostics[0]["code"], "E001");
8787
EXPECT_EQ(diagnostics[0]["source"], "quick-lint-js");
88-
// TODO(strager): Show the declaration as relatedInformation.
88+
// TODO(#200): Show the declaration as relatedInformation.
8989
}
9090

9191
TEST_F(test_lsp_error_reporter, assignment_to_undeclared_variable) {

test/test-options.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,9 @@ TEST(test_options, invalid_vim_file_bufnr) {
230230
}
231231
}
232232

233-
// TODO(strager): Report warning for trailing (ununsed) --vim-file-bufnr.
233+
// TODO(#201): Report warning for trailing (ununsed) --vim-file-bufnr.
234234

235-
// TODO(strager): Report warning for using --vim-file-bufnr without
235+
// TODO(#201): Report warning for using --vim-file-bufnr without
236236
// --output-format.
237237

238238
TEST(test_options, invalid_option) {

test/test-parse-var.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -779,7 +779,7 @@ TEST(test_parse, new_style_variables_cannot_be_named_let) {
779779
EXPECT_EQ(v.variable_declarations[0].kind, variable_kind::_import);
780780
}
781781

782-
// TODO(strager): export implies strict mode (because modules imply strict
782+
// TODO(#73): export implies strict mode (because modules imply strict
783783
// mode).
784784
if ((false)) {
785785
spy_visitor v;

0 commit comments

Comments
 (0)