Add more tests for canonicalize_path

Author: strager

src/quick-lint-js/temporary-directory.h

@@ -15,6 +15,12 @@ void create_directory(const std::string& path);
 
 // Crashes on failure.
 void delete_directory_recursive(const std::string& path);
+
+// Crashes on failure.
+std::string get_current_working_directory();
+
+// Crashes on failure.
+void set_current_working_directory(const char* path);
 }
 
 #endif

src/temporary-directory.cpp

@@ -7,6 +7,7 @@
 #include <cstdlib>
 #include <cstring>
 #include <iostream>
+#include <limits.h>
 #include <quick-lint-js/have.h>
 #include <quick-lint-js/temporary-directory.h>
 #include <quick-lint-js/unreachable.h>
@@ -25,6 +26,10 @@
 #include <sys/stat.h>
 #endif
 
+#if QLJS_HAVE_UNISTD_H
+#include <unistd.h>
+#endif
+
 namespace quick_lint_js {
 #if QLJS_HAVE_MKDTEMP
 std::string make_temporary_directory() {
@@ -133,10 +138,37 @@ void delete_directory_recursive(const std::string &path) {
   ::fts_close(fts);
 }
 #elif QLJS_HAVE_STD_FILESYSTEM
-void delete_directory_recursive(const std::string& path) {
+void delete_directory_recursive(const std::string &path) {
   std::filesystem::remove_all(std::filesystem::path(path));
 }
 #endif
+
+std::string get_current_working_directory() {
+#if QLJS_HAVE_STD_FILESYSTEM
+  return std::filesystem::current_path().string();
+#else
+  std::string cwd;
+  cwd.resize(PATH_MAX);
+  if (!::getcwd(cwd.data(), cwd.size() + 1)) {
+    std::fprintf(stderr, "error: failed to get current directory: %s\n",
+                 std::strerror(errno));
+    std::terminate();
+  }
+  return cwd;
+#endif
+}
+
+void set_current_working_directory(const char *path) {
+#if QLJS_HAVE_STD_FILESYSTEM
+  std::filesystem::current_path(path);
+#else
+  if (::chdir(path) != 0) {
+    std::fprintf(stderr, "error: failed to set current directory to %s: %s\n",
+                 path, std::strerror(errno));
+    std::terminate();
+  }
+#endif
+}
 }
 
 // quick-lint-js finds bugs in JavaScript programs.

test/quick-lint-js/file-matcher.h

@@ -61,6 +61,14 @@ inline ::testing::AssertionResult assert_same_file(
   return assert_same_file(lhs_expr, rhs_expr, lhs_path.c_str(),
                           rhs_path.c_str());
 }
+
+inline ::testing::AssertionResult assert_same_file(const char* lhs_expr,
+                                                   const char* rhs_expr,
+                                                   std::string_view lhs_path,
+                                                   std::string_view rhs_path) {
+  return assert_same_file(lhs_expr, rhs_expr, std::string(lhs_path).c_str(),
+                          std::string(rhs_path).c_str());
+}
 }
 
 #endif

test/test-configuration-loader.cpp

@@ -37,33 +37,6 @@ using namespace std::literals::string_view_literals;
 
 namespace quick_lint_js {
 namespace {
-std::string get_current_working_directory() {
-#if QLJS_HAVE_STD_FILESYSTEM
-  return std::filesystem::current_path().string();
-#else
-  std::string cwd;
-  cwd.resize(PATH_MAX);
-  if (!::getcwd(cwd.data(), cwd.size() + 1)) {
-    std::fprintf(stderr, "error: failed to get current directory: %s\n",
-                 std::strerror(errno));
-    std::terminate();
-  }
-  return cwd;
-#endif
-}
-
-void set_current_working_directory(const char* path) {
-#if QLJS_HAVE_STD_FILESYSTEM
-  std::filesystem::current_path(path);
-#else
-  if (::chdir(path) != 0) {
-    std::fprintf(stderr, "error: failed to set current directory to %s: %s\n",
-                 path, std::strerror(errno));
-    std::terminate();
-  }
-#endif
-}
-
 class test_configuration_loader : public ::testing::Test {
  public:
   std::string make_temporary_directory() {