fix(typescript): don't double-diagnose some statements inside 'declare namespace'

Author: strager

src/quick-lint-js/fe/parse-statement.cpp

@@ -2910,37 +2910,6 @@ void Parser::parse_and_visit_typescript_declare_namespace_or_module(
       case Token_Type::regexp:
         QLJS_UNREACHABLE();
         break;
-
-      case Token_Type::colon:
-      case Token_Type::dot_dot_dot:
-      case Token_Type::kw_case:
-      case Token_Type::kw_catch:
-      case Token_Type::kw_default:
-      case Token_Type::kw_else:
-      case Token_Type::kw_extends:
-      case Token_Type::kw_finally:
-      case Token_Type::question:
-      case Token_Type::question_dot:
-      case Token_Type::right_square: {
-        this->is_current_typescript_namespace_non_empty_ = true;
-        if (this->options_.typescript_definition_file) {
-          this->diag_reporter_->report(Diag_DTS_Non_Declaring_Statement{
-              .first_statement_token = this->peek().span(),
-          });
-        } else {
-          this->diag_reporter_->report(
-              Diag_Declare_Namespace_Cannot_Contain_Statement{
-                  .first_statement_token = this->peek().span(),
-                  .declare_keyword = declare_keyword_span,
-              });
-        }
-        bool parsed_statement = this->parse_and_visit_statement(
-            v, Parse_Statement_Options{
-                   .possibly_followed_by_another_statement = true,
-               });
-        QLJS_ASSERT(parsed_statement);
-        break;
-      }
       }
     }
   stop_parsing_body:

test/test-parse-typescript-declare-namespace.cpp

@@ -1029,6 +1029,7 @@ TEST_F(
       u8"switch (true) { default: declare namespace ns { break; } }"_sv,  //
       u8"                                                ^^^^^ Diag_Invalid_Break"_diag,
       typescript_options);
+
   test_parse_and_visit_module(
       u8"declare namespace ns { continue; }"_sv,  //
       u8"                       ^^^^^^^^ Diag_Invalid_Continue"_diag,
@@ -1037,6 +1038,19 @@ TEST_F(
       u8"for (;;) { declare namespace ns { continue; } }"_sv,  //
       u8"                                  ^^^^^^^^ Diag_Invalid_Continue"_diag,
       typescript_options);
+
+  test_parse_and_visit_module(
+      u8"declare namespace ns { else { } }"_sv,  //
+      u8"                       ^^^^ Diag_Else_Has_No_If"_diag,
+      typescript_options);
+  test_parse_and_visit_module(
+      u8"declare namespace ns { catch { } }"_sv,  //
+      u8"                       ^^^^^ Diag_Catch_Without_Try"_diag,
+      typescript_options);
+  test_parse_and_visit_module(
+      u8"declare namespace ns { finally { } }"_sv,  //
+      u8"                       ^^^^^^^ Diag_Finally_Without_Try"_diag,
+      typescript_options);
 }
 
 TEST_F(Test_Parse_TypeScript_Declare_Namespace,