Skip to content

Commit 6697f39

Browse files
committed
Security: Vim: don't search in node_modules by default
1 parent 683f617 commit 6697f39

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

plugin/vim/quick-lint-js.vim/ale_linters/javascript/quick_lint_js.vim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
" https://github.com/dense-analysis/ale
66

77
call ale#Set('javascript_quick_lint_js_executable', 'quick-lint-js')
8-
call ale#Set('javascript_quick_lint_js_use_global', get(g:, 'ale_use_global_executables', 0))
8+
call ale#Set('javascript_quick_lint_js_use_global', get(g:, 'ale_use_global_executables', v:true))
99

1010
" TODO(strager): Make quick-lint-js-lsp the default when the bugs have been
1111
" ironed out:

plugin/vim/quick-lint-js.vim/doc/quick-lint-js.txt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,17 @@ g:ale_javascript_quick_lint_js_use_global
9191
*g:ale_javascript_quick_lint_js_use_global*
9292
*b:ale_javascript_quick_lint_js_use_global*
9393
Type: |Boolean|
94-
Default: `v:false`
94+
Default: `v:true`
9595

9696
Set this variable to `v:false` to search for `quick-lint-js` in `node_modules`
9797
first, and if it's not found, use |g:ale_javascript_quick_lint_js_executable|.
9898

9999
Set this variable to `v:true` to only use
100100
|g:ale_javascript_quick_lint_js_executable|.
101101

102+
For security reasons, we recommend leaving this variable at its default value
103+
(`v:true`). If this variable is set to `v:false`, then a malicious project
104+
could run arbitrary code on your computer through `node_modules` if you open a
105+
JavaScript file.
106+
102107
vim:tw=78:ts=8:noet:ft=help:norl:

0 commit comments

Comments
 (0)