fix span E094

Now if there is a missing body for a for loop, the error points to the end of the for loop defintion where body should start

Author: ahmafi

src/quick-lint-js/parse.h

@@ -2482,9 +2482,9 @@ class parser {
     bool parsed_body =
         this->parse_and_visit_statement_disallowing_declaration(v);
     if (!parsed_body) {
+      const char8 *here = this->lexer_.end_of_previous_token();
       this->error_reporter_->report(error_missing_body_for_for_statement{
-          .for_and_header = source_code_span(
-              for_token_span.begin(), this->lexer_.end_of_previous_token()),
+          .for_and_header = source_code_span(here, here),
       });
     }
 

test/test-parse-loop.cpp

@@ -918,10 +918,11 @@ TEST(test_parse, for_loop_without_body) {
                                       "visit_variable_use",          // myArray
                                       "visit_variable_declaration",  // x
                                       "visit_exit_for_scope"));
-    EXPECT_THAT(v.errors,
-                ElementsAre(ERROR_TYPE_FIELD(
-                    error_missing_body_for_for_statement, for_and_header,
-                    offsets_matcher(&code, 0, u8"for (let x of myArray)"))));
+    EXPECT_THAT(
+        v.errors,
+        ElementsAre(ERROR_TYPE_FIELD(
+            error_missing_body_for_for_statement, for_and_header,
+            offsets_matcher(&code, strlen(u8"for (let x of myArray)"), u8""))));
   }
 
   {
@@ -938,8 +939,8 @@ TEST(test_parse, for_loop_without_body) {
     EXPECT_THAT(v.errors,
                 ElementsAre(ERROR_TYPE_FIELD(
                     error_missing_body_for_for_statement, for_and_header,
-                    offsets_matcher(&code, strlen(u8"{ "),
-                                    u8"for (let x of myArray)"))));
+                    offsets_matcher(&code, strlen(u8"{ for (let x of myArray)"),
+                                    u8""))));
   }
 }