Factor JS<->WASM interface out of VS Code extension

Author: strager

.github/workflows/build-and-test-plugin-vscode.yml

@@ -32,7 +32,7 @@ jobs:
       - name: C++ build
         run: emmake cmake --build build --target quick-lint-js-vscode quick-lint-js-vscode-licenses
       - name: C++ install
-        run: emmake cmake --install build --component vscode --prefix plugin/vscode
+        run: emmake cmake --install build --component vscode --prefix wasm
 
       - name: JS configure
         run: cd plugin/vscode && yarn

CMakeLists.txt

@@ -32,10 +32,10 @@ endif ()
 add_subdirectory(docs)
 add_subdirectory(fuzz)
 add_subdirectory(plugin/vim)
-add_subdirectory(plugin/vscode)
 add_subdirectory(plugin/emacs)
 add_subdirectory(src)
 add_subdirectory(tools)
+add_subdirectory(wasm)
 add_subdirectory(website/demo)
 add_subdirectory(completions)
 include(CTest)

plugin/vscode/.gitignore

@@ -1,5 +1,3 @@
 /.vscode-test/
-/build-emscripten/
-/dist/
 /node_modules/
 /quick-lint-js-*.vsix

plugin/vscode/.vscodeignore

@@ -2,8 +2,8 @@
 
 !LICENSE
 !README.md
-!dist/copyright.txt
-!dist/quick-lint-js-vscode.wasm
 !extension.js
+!node_modules/quick-lint-js-wasm/dist/copyright.txt
+!node_modules/quick-lint-js-wasm/dist/quick-lint-js-vscode.wasm
+!node_modules/quick-lint-js-wasm/quick-lint-js.js
 !package.json
-!quick-lint-js.js

plugin/vscode/BUILDING.md

@@ -5,13 +5,8 @@ editor][VisualStudioCode].
 
 ## Building
 
-To build the extension, install the [emscripten SDK][emscripten-sdk], [Ninja][],
-and [Node.js][], then run the following commands:
-
-    $ cd plugin/vscode/  # Navigate to this directory.
-    $ emcmake cmake -S ../.. -B build-emscripten -G Ninja -DCMAKE_BUILD_TYPE=Release
-    $ emmake ninja -C build-emscripten quick-lint-js-vscode quick-lint-js-vscode-licenses
-    $ emmake cmake --install build-emscripten --component vscode --prefix .
+To build this extension, first [build the quick-lint-js-wasm
+package](../../wasm/README.md#Building).
 
 Then, run the following command to create `quick-lint-js-0.2.0.vsix`:
 
@@ -22,11 +17,6 @@ Then, run the following command to create `quick-lint-js-0.2.0.vsix`:
 After [building](#Building), run `yarn test` to run the automated test suite.
 Packaging is not necessary to run `yarn test`.
 
-To manually test the extension's WebAssembly bindings, [build](#Building), then
-run `cli.js` :
-
-    $ node plugin/vscode/cli.js PATH_TO_YOUR_JS_FILE.js
-
 [Ninja]: https://ninja-build.org/
 [Node.js]: https://nodejs.org/
 [VisualStudioCode]: https://code.visualstudio.com/

plugin/vscode/extension.js

@@ -9,7 +9,7 @@ let {
   DiagnosticSeverity,
   ProcessCrashed,
   createProcessFactoryAsync,
-} = require("./quick-lint-js.js");
+} = require("quick-lint-js-wasm/quick-lint-js.js");
 
 // TODO(strager): Allow developers to reload the .wasm file.
 let processFactoryPromise = createProcessFactoryAsync();

plugin/vscode/package.json

@@ -40,5 +40,8 @@
     "prettier": "2.1.2",
     "tape": "5.0.1",
     "vscode-test": "1.4.1"
+  },
+  "dependencies": {
+    "quick-lint-js-wasm": "../../wasm"
   }
 }

plugin/vscode/test/other-tests.js

@@ -10,7 +10,7 @@ require("module").Module._initPaths();
 
 let assert = require("assert");
 let extension = require("../extension.js");
-let qljs = require("../quick-lint-js.js");
+let qljs = require("quick-lint-js-wasm/quick-lint-js.js");
 let vscode = require("./mock/vscode.js");
 let { testMainAsync } = require("./test-support.js");
 

plugin/vscode/yarn.lock

@@ -433,6 +433,9 @@ [email protected]:
   resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.1.2.tgz#3050700dae2e4c8b67c4c3f666cdb8af405e1ce5"
   integrity sha512-16c7K+x4qVlJg9rEbXl7HEGmQyZlG4R9AgP+oHKRMsMsuk8s+ATStlf1NpDqyBI1HpVyfjLOeMhH2LvuNvV5Vg==
 
+quick-lint-js-wasm@../../wasm:
+  version "0.0.0"
+
 regexp.prototype.flags@^1.3.0:
   version "1.3.0"
   resolved "https://registry.yarnpkg.com/regexp.prototype.flags/-/regexp.prototype.flags-1.3.0.tgz#7aba89b3c13a64509dabcf3ca8d9fbb9bdf5cb75"

wasm/.gitignore

@@ -0,0 +1,3 @@
+/build-emscripten/
+/dist/
+/node_modules/