refactor(container): discourage using size_t with padded_string

Author: strager

src/quick-lint-js/container/padded-string.h

@@ -51,11 +51,6 @@ class padded_string {
     return this->data_[narrow_cast<unsigned>(index)];
   }
 
-  const char8 &operator[](std::size_t index) const noexcept {
-    QLJS_ASSERT(index <= narrow_cast<std::size_t>(this->size()));
-    return this->data_[index];
-  }
-
   void resize(size_type new_size);
   void resize_grow_uninitialized(size_type new_size);
 

src/quick-lint-js/port/char8.cpp

@@ -42,6 +42,8 @@ std::size_t strlen(const char8 *s) {
   return std::strlen(reinterpret_cast<const char *>(s));
 }
 
+int strlen_i(const char8 *s) { return narrow_cast<int>(strlen(s)); }
+
 const char8 *strchr(const char8 *haystack, char8 needle) {
   return reinterpret_cast<const char8 *>(std::strchr(
       reinterpret_cast<const char *>(haystack), static_cast<char>(needle)));

src/quick-lint-js/port/char8.h

@@ -47,6 +47,7 @@ std::string_view to_string_view(string8_view);
 string8_view to_string8_view(std::string_view);
 
 std::size_t strlen(const char8 *);
+int strlen_i(const char8 *);
 const char8 *strchr(const char8 *haystack, char8 needle);
 const char8 *strstr(const char8 *haystack, const char8 *needle);
 std::size_t strspn(const char8 *haystack, const char8 *needles);

test/test-lex.cpp

@@ -3342,8 +3342,8 @@ TEST_F(test_lex, jsx_string_ignores_comments) {
     l.skip_in_jsx();  // Ignore '!'.
 
     EXPECT_EQ(l.peek().type, token_type::string);
-    EXPECT_EQ(l.peek().begin, &code[strlen(u8"! ")]);
-    EXPECT_EQ(l.peek().end, &code[strlen(u8"! 'hello // '")])
+    EXPECT_EQ(l.peek().begin, &code[strlen_i(u8"! ")]);
+    EXPECT_EQ(l.peek().end, &code[strlen_i(u8"! 'hello // '")])
         << "string should end at ', treating // as part of the string";
 
     l.skip_in_jsx();
@@ -3360,8 +3360,8 @@ TEST_F(test_lex, jsx_string_ignores_comments) {
     l.skip_in_jsx();  // Ignore '!'.
 
     EXPECT_EQ(l.peek().type, token_type::string);
-    EXPECT_EQ(l.peek().begin, &code[strlen(u8"! ")]);
-    EXPECT_EQ(l.peek().end, &code[strlen(u8R"(! "hello/* not")")])
+    EXPECT_EQ(l.peek().begin, &code[strlen_i(u8"! ")]);
+    EXPECT_EQ(l.peek().end, &code[strlen_i(u8R"(! "hello/* not")")])
         << "string should end at \", treating /* as part of the string";
 
     l.skip_in_jsx();
@@ -3453,8 +3453,8 @@ TEST_F(test_lex, jsx_text_children) {
     l.skip_in_jsx_children();  // Skip '>'.
 
     EXPECT_EQ(l.peek().type, token_type::less);
-    EXPECT_EQ(l.peek().begin, &code[strlen(u8"<>hello")]);
-    EXPECT_EQ(l.peek().end, &code[strlen(u8"<>hello<")]);
+    EXPECT_EQ(l.peek().begin, &code[strlen_i(u8"<>hello")]);
+    EXPECT_EQ(l.peek().end, &code[strlen_i(u8"<>hello<")]);
     EXPECT_THAT(errors.errors, IsEmpty());
   }
 
@@ -3467,8 +3467,8 @@ TEST_F(test_lex, jsx_text_children) {
     l.skip_in_jsx();  // Ignore '<'.
 
     EXPECT_EQ(l.peek().type, token_type::greater);
-    EXPECT_EQ(l.peek().begin, &code[strlen(u8"<")]);
-    EXPECT_EQ(l.peek().end, &code[strlen(u8"<>")]);
+    EXPECT_EQ(l.peek().begin, &code[strlen_i(u8"<")]);
+    EXPECT_EQ(l.peek().end, &code[strlen_i(u8"<>")]);
     l.skip_in_jsx_children();
 
     EXPECT_EQ(l.peek().type, token_type::end_of_file);