fix(lsp): fix trace_flusher::is_enabled not returning false

trace_flusher::disable doesn't change the trace_directory_ variable.
This causes is_enabled to continue to return true. Fix this by clearning
trace_directory_.

Author: strager

src/trace-flusher.cpp

@@ -85,6 +85,7 @@ void trace_flusher::disable() {
   for (auto& t : this->registered_threads_) {
     t->thread_writer->store(nullptr);
   }
+  this->trace_directory_.clear();
 }
 
 void trace_flusher::create_and_enable_in_child_directory(

test/test-trace-flusher.cpp

@@ -86,6 +86,14 @@ TEST_F(test_trace_flusher, enabling_creates_metadata_file) {
       << "TSDL specification: https://diamon.org/ctf/#spec7.1";
 }
 
+TEST_F(test_trace_flusher, enabling_enables) {
+  trace_flusher flusher;
+  EXPECT_FALSE(flusher.is_enabled());
+  auto result = flusher.enable_for_directory(this->trace_dir);
+  ASSERT_TRUE(result.ok()) << result.error_to_string();
+  EXPECT_TRUE(flusher.is_enabled());
+}
+
 TEST_F(test_trace_flusher, enabling_fails_if_directory_is_missing) {
   trace_flusher flusher;
   auto result =
@@ -225,6 +233,16 @@ TEST_F(test_trace_flusher, cannot_write_events_after_enabling_then_disabling) {
   EXPECT_FALSE(writer);
 }
 
+TEST_F(test_trace_flusher, disabling_disables) {
+  trace_flusher flusher;
+  auto result = flusher.enable_for_directory(this->trace_dir);
+  ASSERT_TRUE(result.ok()) << result.error_to_string();
+  ASSERT_TRUE(flusher.is_enabled());
+
+  flusher.disable();
+  EXPECT_FALSE(flusher.is_enabled());
+}
+
 TEST_F(test_trace_flusher,
        can_write_events_after_enabling_then_enabling_again) {
   std::string trace_dir_2 = this->make_temporary_directory();