refactor: rename report_impl parameter: error -> diag

Author: strager

plugin/vscode/quick-lint-js/vscode-diag-reporter.h

@@ -137,14 +137,14 @@ class vscode_diag_reporter final : public diag_reporter {
 
   ::Napi::Array diagnostics() const { return this->diagnostics_; }
 
-  void report_impl(diag_type type, void* error) override {
+  void report_impl(diag_type type, void* diag) override {
     vscode_diag_formatter formatter(
         /*vscode=*/this->vscode_,
         /*env=*/this->env_,
         /*diagnostics=*/this->diagnostics_,
         /*locator=*/this->locator_,
         /*document_uri=*/this->document_uri_);
-    formatter.format(get_diagnostic_info(type), error);
+    formatter.format(get_diagnostic_info(type), diag);
   }
 
  private:

src/buffering-diag-reporter.cpp

@@ -56,7 +56,7 @@ buffering_diag_reporter &buffering_diag_reporter::operator=(
 
 buffering_diag_reporter::~buffering_diag_reporter() = default;
 
-void buffering_diag_reporter::report_impl(diag_type type, void *error) {
+void buffering_diag_reporter::report_impl(diag_type type, void *diag) {
   static constexpr unsigned char error_sizes[] = {
 #define QLJS_DIAG_TYPE(name, code, severity, struct_body, format) \
   sizeof(::quick_lint_js::name),
@@ -66,7 +66,7 @@ void buffering_diag_reporter::report_impl(diag_type type, void *error) {
 
   impl::any_error &e = this->impl_->errors_.emplace_back();
   e.type = type;
-  std::memcpy(&e.error, error, error_sizes[static_cast<std::ptrdiff_t>(type)]);
+  std::memcpy(&e.error, diag, error_sizes[static_cast<std::ptrdiff_t>(type)]);
 }
 
 void buffering_diag_reporter::copy_into(diag_reporter *other) const {

src/c-api-diag-reporter.cpp

@@ -35,9 +35,9 @@ void c_api_diag_reporter<Diagnostic, Locator>::reset() {
 
 template <class Diagnostic, class Locator>
 void c_api_diag_reporter<Diagnostic, Locator>::report_impl(diag_type type,
-                                                           void *error) {
+                                                           void *diag) {
   c_api_diag_formatter formatter(this);
-  formatter.format(get_diagnostic_info(type), error);
+  formatter.format(get_diagnostic_info(type), diag);
 }
 
 template <class Diagnostic, class Locator>

src/emacs-lisp-diag-reporter.cpp

@@ -22,11 +22,11 @@ void emacs_lisp_diag_reporter::set_source(padded_string_view input) {
   this->locator_.emplace(input);
 }
 
-void emacs_lisp_diag_reporter::report_impl(diag_type type, void *error) {
+void emacs_lisp_diag_reporter::report_impl(diag_type type, void *diag) {
   QLJS_ASSERT(this->locator_.has_value());
   emacs_lisp_diag_formatter formatter(/*output=*/&this->output_,
                                       /*locator=*/*this->locator_);
-  formatter.format(get_diagnostic_info(type), error);
+  formatter.format(get_diagnostic_info(type), diag);
 }
 
 emacs_lisp_diag_formatter::emacs_lisp_diag_formatter(output_stream *output,

src/lsp-diag-reporter.cpp

@@ -28,14 +28,14 @@ lsp_diag_reporter::lsp_diag_reporter(byte_buffer &output,
 
 void lsp_diag_reporter::finish() { this->output_.append_copy(u8"]"sv); }
 
-void lsp_diag_reporter::report_impl(diag_type type, void *error) {
+void lsp_diag_reporter::report_impl(diag_type type, void *diag) {
   if (this->need_comma_) {
     this->output_.append_copy(u8",\n"sv);
   }
   this->need_comma_ = true;
   lsp_diag_formatter formatter(/*output=*/this->output_,
                                /*locator=*/this->locator_);
-  formatter.format(get_diagnostic_info(type), error);
+  formatter.format(get_diagnostic_info(type), diag);
 }
 
 lsp_diag_formatter::lsp_diag_formatter(byte_buffer &output,

src/quick-lint-js/buffering-diag-reporter.h

@@ -20,7 +20,7 @@ class buffering_diag_reporter final : public diag_reporter {
 
   ~buffering_diag_reporter() override;
 
-  void report_impl(diag_type type, void *error) override;
+  void report_impl(diag_type type, void *diag) override;
 
   void copy_into(diag_reporter *other) const;
   void move_into(diag_reporter *other);

src/quick-lint-js/c-api-diag-reporter.h

@@ -35,7 +35,7 @@ class c_api_diag_reporter final : public diag_reporter {
 
   const Diagnostic *get_diagnostics();
 
-  void report_impl(diag_type type, void *error) override;
+  void report_impl(diag_type type, void *diag) override;
 
  private:
   char8 *allocate_c_string(string8_view);

src/quick-lint-js/diag-reporter.h

@@ -20,13 +20,13 @@ class diag_reporter {
   virtual ~diag_reporter() = default;
 
 #define QLJS_DIAG_TYPE(name, code, severity, struct_body, format) \
-  void report(name error) {                                       \
-    this->report_impl(error_type_from_type<name>, &error);        \
+  void report(name diag) {                                        \
+    this->report_impl(error_type_from_type<name>, &diag);         \
   }
   QLJS_X_DIAG_TYPES
 #undef QLJS_DIAG_TYPE
 
-  virtual void report_impl(diag_type type, void *error) = 0;
+  virtual void report_impl(diag_type type, void *diag) = 0;
 };
 
 class null_diag_reporter : public diag_reporter {

src/quick-lint-js/emacs-lisp-diag-reporter.h

@@ -26,7 +26,7 @@ class emacs_lisp_diag_reporter final : public diag_reporter {
   void set_source(padded_string_view input);
   void finish();
 
-  void report_impl(diag_type type, void *error) override;
+  void report_impl(diag_type type, void *diag) override;
 
  private:
   output_stream &output_;

src/quick-lint-js/lsp-diag-reporter.h

@@ -29,7 +29,7 @@ class lsp_diag_reporter final : public diag_reporter {
 
   void finish();
 
-  void report_impl(diag_type type, void *error) override;
+  void report_impl(diag_type type, void *diag) override;
 
  private:
   byte_buffer &output_;