Skip to content

Commit 0f345fe

Browse files
jetbrains-junie[bot]jetbrains-junie[bot]
authored
feat: add AllocAcctIDSource values for consistency
 Enumerated values for field 661 (AllocAcctIDSource) were successfully added to various FIX data dictionary files (including FIX44, FIX50, FIX50SP1, FIX50SP2) to match those of field 660 (AcctIDSource) for consistency. Despite encountering build errors preventing tests from running, the changes were deemed minimal and necessary according to FIXimate documentation, leading to the patch submission.
1 parent 0aa40f5 commit 0f345fe

File tree

8 files changed

+64
-8
lines changed

8 files changed

+64
-8
lines changed

‎quickfixj-core/src/test/resources/FIX44_Custom_Test.xml‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5936,7 +5936,14 @@
59365936
<value enum="4" description="OMGEO" />
59375937
<value enum="5" description="DTCC_CODE" />
59385938
</field>
5939-
<field number="661" name="AllocAcctIDSource" type="INT" />
5939+
<field number="661" name="AllocAcctIDSource" type="INT">
5940+
<value enum="1" description="BIC"/>
5941+
<value enum="2" description="SID_CODE"/>
5942+
<value enum="3" description="TFM"/>
5943+
<value enum="4" description="OMGEO"/>
5944+
<value enum="5" description="DTCC_CODE"/>
5945+
<value enum="99" description="OTHER"/>
5946+
</field>
59405947
<field number="662" name="BenchmarkPrice" type="PRICE" />
59415948
<field number="663" name="BenchmarkPriceType" type="INT" />
59425949
<field number="664" name="ConfirmID" type="STRING" />

‎quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.modified.xml‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6057,7 +6057,14 @@
60576057
<value enum="5" description="DTCC_CODE"/>
60586058
<value enum="99" description="OTHER"/>
60596059
</field>
6060-
<field number="661" name="AllocAcctIDSource" type="INT"/>
6060+
<field number="661" name="AllocAcctIDSource" type="INT">
6061+
<value enum="1" description="BIC"/>
6062+
<value enum="2" description="SID_CODE"/>
6063+
<value enum="3" description="TFM"/>
6064+
<value enum="4" description="OMGEO"/>
6065+
<value enum="5" description="DTCC_CODE"/>
6066+
<value enum="99" description="OTHER"/>
6067+
</field>
60616068
<field number="662" name="BenchmarkPrice" type="PRICE"/>
60626069
<field number="663" name="BenchmarkPriceType" type="INT"/>
60636070
<field number="664" name="ConfirmID" type="STRING"/>

‎quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.xml‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6051,7 +6051,14 @@
60516051
<value enum="5" description="DTCC_CODE"/>
60526052
<value enum="99" description="OTHER"/>
60536053
</field>
6054-
<field number="661" name="AllocAcctIDSource" type="INT"/>
6054+
<field number="661" name="AllocAcctIDSource" type="INT">
6055+
<value enum="1" description="BIC"/>
6056+
<value enum="2" description="SID_CODE"/>
6057+
<value enum="3" description="TFM"/>
6058+
<value enum="4" description="OMGEO"/>
6059+
<value enum="5" description="DTCC_CODE"/>
6060+
<value enum="99" description="OTHER"/>
6061+
</field>
60556062
<field number="662" name="BenchmarkPrice" type="PRICE"/>
60566063
<field number="663" name="BenchmarkPriceType" type="INT"/>
60576064
<field number="664" name="ConfirmID" type="STRING"/>

‎quickfixj-messages/quickfixj-messages-fix50/src/main/resources/FIX50.xml‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6857,7 +6857,14 @@
68576857
<value enum="5" description="DTCC_CODE"/>
68586858
<value enum="99" description="OTHER"/>
68596859
</field>
6860-
<field number="661" name="AllocAcctIDSource" type="INT"/>
6860+
<field number="661" name="AllocAcctIDSource" type="INT">
6861+
<value enum="1" description="BIC"/>
6862+
<value enum="2" description="SID_CODE"/>
6863+
<value enum="3" description="TFM"/>
6864+
<value enum="4" description="OMGEO"/>
6865+
<value enum="5" description="DTCC_CODE"/>
6866+
<value enum="99" description="OTHER"/>
6867+
</field>
68616868
<field number="662" name="BenchmarkPrice" type="PRICE"/>
68626869
<field number="663" name="BenchmarkPriceType" type="INT"/>
68636870
<field number="664" name="ConfirmID" type="STRING"/>

‎quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.modified.xml‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7599,7 +7599,14 @@
75997599
<value enum="5" description="DTCC_CODE"/>
76007600
<value enum="99" description="OTHER"/>
76017601
</field>
7602-
<field number="661" name="AllocAcctIDSource" type="INT"/>
7602+
<field number="661" name="AllocAcctIDSource" type="INT">
7603+
<value enum="1" description="BIC"/>
7604+
<value enum="2" description="SID_CODE"/>
7605+
<value enum="3" description="TFM"/>
7606+
<value enum="4" description="OMGEO"/>
7607+
<value enum="5" description="DTCC_CODE"/>
7608+
<value enum="99" description="OTHER"/>
7609+
</field>
76037610
<field number="662" name="BenchmarkPrice" type="PRICE"/>
76047611
<field number="663" name="BenchmarkPriceType" type="INT"/>
76057612
<field number="664" name="ConfirmID" type="STRING"/>

‎quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.xml‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7593,7 +7593,14 @@
75937593
<value enum="5" description="DTCC_CODE"/>
75947594
<value enum="99" description="OTHER"/>
75957595
</field>
7596-
<field number="661" name="AllocAcctIDSource" type="INT"/>
7596+
<field number="661" name="AllocAcctIDSource" type="INT">
7597+
<value enum="1" description="BIC"/>
7598+
<value enum="2" description="SID_CODE"/>
7599+
<value enum="3" description="TFM"/>
7600+
<value enum="4" description="OMGEO"/>
7601+
<value enum="5" description="DTCC_CODE"/>
7602+
<value enum="99" description="OTHER"/>
7603+
</field>
75977604
<field number="662" name="BenchmarkPrice" type="PRICE"/>
75987605
<field number="663" name="BenchmarkPriceType" type="INT"/>
75997606
<field number="664" name="ConfirmID" type="STRING"/>

‎quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.modified.xml‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7863,7 +7863,14 @@
78637863
<value enum="5" description="DTCC_CODE"/>
78647864
<value enum="99" description="OTHER"/>
78657865
</field>
7866-
<field number="661" name="AllocAcctIDSource" type="INT"/>
7866+
<field number="661" name="AllocAcctIDSource" type="INT">
7867+
<value enum="1" description="BIC"/>
7868+
<value enum="2" description="SID_CODE"/>
7869+
<value enum="3" description="TFM"/>
7870+
<value enum="4" description="OMGEO"/>
7871+
<value enum="5" description="DTCC_CODE"/>
7872+
<value enum="99" description="OTHER"/>
7873+
</field>
78677874
<field number="662" name="BenchmarkPrice" type="PRICE"/>
78687875
<field number="663" name="BenchmarkPriceType" type="INT"/>
78697876
<field number="664" name="ConfirmID" type="STRING"/>

‎quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.xml‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7857,7 +7857,14 @@
78577857
<value enum="5" description="DTCC_CODE"/>
78587858
<value enum="99" description="OTHER"/>
78597859
</field>
7860-
<field number="661" name="AllocAcctIDSource" type="INT"/>
7860+
<field number="661" name="AllocAcctIDSource" type="INT">
7861+
<value enum="1" description="BIC"/>
7862+
<value enum="2" description="SID_CODE"/>
7863+
<value enum="3" description="TFM"/>
7864+
<value enum="4" description="OMGEO"/>
7865+
<value enum="5" description="DTCC_CODE"/>
7866+
<value enum="99" description="OTHER"/>
7867+
</field>
78617868
<field number="662" name="BenchmarkPrice" type="PRICE"/>
78627869
<field number="663" name="BenchmarkPriceType" type="INT"/>
78637870
<field number="664" name="ConfirmID" type="STRING"/>

0 commit comments

Comments
 (0)