Updates examples repo.

Author: ackleymi

.github/dependabot.yml

@@ -0,0 +1,7 @@
+version: 2
+updates:
+- package-ecosystem: gomod
+  directory: "/"
+  schedule:
+    interval: daily
+  open-pull-requests-limit: 10

.github/workflows/ci.yaml

@@ -0,0 +1,38 @@
+name: CI
+on:
+  push:
+    tags:
+      - v*
+    branches:
+      - master
+      - main
+  pull_request:
+    branches:
+      - master
+      - main
+jobs:
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: v1.41
+
+  build:
+    name: build
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        go: [1.16, 1.15]
+    steps:
+      - name: Setup
+        uses: actions/setup-go@v2
+        with:
+          go-version: ${{ matrix.go }}
+      - name: Check out source
+        uses: actions/checkout@v2
+      - name: Build
+        run: make build

.github/workflows/codeql-analysis.yml

@@ -0,0 +1,60 @@
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ main ]
+  schedule:
+    - cron: '42 21 * * 3'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'go' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
+        # Learn more:
+        # https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v2
+
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v1
+      with:
+        languages: ${{ matrix.language }}
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
+        # queries: ./path/to/local/query, your-org/your-repo/queries@main
+
+    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
+    # If this step fails, then you should remove it and run the build manually (see below)
+    - name: Autobuild
+      uses: github/codeql-action/autobuild@v1
+
+    # ℹ️ Command-line programs to run using the OS shell.
+    # 📚 https://git.io/JvXDl
+
+    # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
+    #    and modify them (or add more) to build your code if your project
+    #    uses a compiled language
+
+    #- run: |
+    #   make bootstrap
+    #   make release
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v1

.gitignore

@@ -3,3 +3,4 @@ tmp
 vendor
 bin
 .exe
+dist/

.travis.yml

@@ -1,6 +1,6 @@
 The QuickFIX Software License, Version 1.0
 
-Copyright (c) 2001-2010 quickfixengine.org  All rights
+Copyright (c) 2001-present quickfixengine.org  All rights
 reserved.
 
 Redistribution and use in source and binary forms, with or without

LICENSE.txt

@@ -3,7 +3,7 @@ SHELL := /bin/bash
 test: lint vet build
 
 lint:
-	golint ./...
+	golangci-lint run
 
 vet:
 	go vet ./...

Makefile

@@ -1,33 +1,28 @@
-Example QuickFIX/Go Applications
-================================
+# Example QuickFIX/Go Applications
 
-[![Build Status](https://travis-ci.org/quickfixgo/examples.svg?branch=master)](https://travis-ci.org/quickfixgo/examples)
+[![Build Status](https://github.com/quickfixgo/examples/workflows/CI/badge.svg)](https://github.com/quickfixgo/examples/actions) [![GoDoc](https://godoc.org/github.com/quickfixgo/examples?status.png)](https://godoc.org/github.com/quickfixgo/examples) [![Go Report Card](https://goreportcard.com/badge/github.com/quickfixgo/examples)](https://goreportcard.com/report/github.com/quickfixgo/examples)
 
 * TradeClient is a simple console based trading client
 * Executor is a server that fills every limit order it receives
 * OrderMatch is a primitive matching engine 
 
 All examples have been ported from [QuickFIX](http://quickfixengine.org)
 
-Installation
-------------
+## Installation
 
-To build and run the examples, you will first need [Go](http://www.golang.org) installed on your machine (version 1.6+ is *required*).
+### Build From Source
+To build and run the examples, you will first need [Go](https://www.golang.org) installed on your machine
 
-For local dev first make sure Go is properly installed, including setting up a [GOPATH](http://golang.org/doc/code.html#GOPATH).
-
-Next, using [Git](https://git-scm.com/), clone this repository into `$GOPATH/src/github.com/quickfixgo/examples`. All the necessary dependencies are either vendored, so you just need to type `make`. This will compile and install the examples into `$GOPATH/bin`. If this exits with exit status 0, then everything is working!
+Next, clone this repository with `git clone [email protected]:quickfixgo/examples.git`. All the necessary dependencies are vendored, so you just need to type `make build`. This will compile and install the examples into the `./bin` dir in the local copy of the repo. If this exits with exit status 0, then everything is working!
 
 ```sh
-$ make
+make build
 ```
 
-Running the Examples
---------------------
+### Running the Examples
 
-Following installation, the examples can be found in `$GOPATH/bin`.  The examples are meant to be run in pairs- the TradeClient as a client of either the Executor or OrderMatch.  By default, the examples will load the default configurations named after the example apps provided in the `config/` root directory.   Eg, running `$GOPATH/bin/tradeclient` will load the `config/tradeclient.cfg` configuration.  Each example can be run with a custom configuration as a command line argument (`$GOPATH/bin/tradeclient my_trade_client.cfg`).
+Following installation, the examples can be found in `./bin`.  The examples are meant to be run in pairs- the TradeClient as a client of either the Executor or OrderMatch.  By default, the examples will load the default configurations named after the example apps provided in the `config/` root directory.  <i>i.e.</i>, running `./bin/tradeclient` will load the `config/tradeclient.cfg` configuration.  Each example can be run with a custom configuration as a command line argument (`./bin/tradeclient my_trade_client.cfg`).
 
-Licensing
----------
+### Licensing
 
-This software is available under the QuickFIX Software License. Please see the [LICENSE.txt](https://github.com/quickfixgo/examples/blob/master/LICENSE.txt) for the terms specified by the QuickFIX Software License.
+This software is available under the QuickFIX Software License. Please see the [LICENSE.txt](https://github.com/quickfixgo/examples/blob/main/LICENSE.txt) for the terms specified by the QuickFIX Software License.

README.md

@@ -4,6 +4,7 @@ import (
 	"flag"
 	"fmt"
 	"path"
+	"syscall"
 
 	"github.com/quickfixgo/enum"
 	"github.com/quickfixgo/field"
@@ -59,10 +60,10 @@ func (e *executor) genExecID() field.ExecIDField {
 }
 
 //quickfix.Application interface
-func (e executor) OnCreate(sessionID quickfix.SessionID)                           { return }
-func (e executor) OnLogon(sessionID quickfix.SessionID)                            { return }
-func (e executor) OnLogout(sessionID quickfix.SessionID)                           { return }
-func (e executor) ToAdmin(msg *quickfix.Message, sessionID quickfix.SessionID)     { return }
+func (e executor) OnCreate(sessionID quickfix.SessionID)                           {}
+func (e executor) OnLogon(sessionID quickfix.SessionID)                            {}
+func (e executor) OnLogout(sessionID quickfix.SessionID)                           {}
+func (e executor) ToAdmin(msg *quickfix.Message, sessionID quickfix.SessionID)     {}
 func (e executor) ToApp(msg *quickfix.Message, sessionID quickfix.SessionID) error { return nil }
 func (e executor) FromAdmin(msg *quickfix.Message, sessionID quickfix.SessionID) quickfix.MessageRejectError {
 	return nil
@@ -123,7 +124,10 @@ func (e *executor) OnFIX40NewOrderSingle(msg fix40nos.NewOrderSingle, sessionID
 	}
 	execReport.SetClOrdID(clOrdID)
 
-	quickfix.SendToTarget(execReport, sessionID)
+	sendErr := quickfix.SendToTarget(execReport, sessionID)
+	if sendErr != nil {
+		fmt.Println(sendErr)
+	}
 
 	return nil
 }
@@ -179,8 +183,10 @@ func (e *executor) OnFIX41NewOrderSingle(msg fix41nos.NewOrderSingle, sessionID
 	}
 	execReport.SetClOrdID(clOrdID)
 
-	quickfix.SendToTarget(execReport, sessionID)
-
+	sendErr := quickfix.SendToTarget(execReport, sessionID)
+	if sendErr != nil {
+		fmt.Println(sendErr)
+	}
 	return
 }
 
@@ -245,7 +251,10 @@ func (e *executor) OnFIX42NewOrderSingle(msg fix42nos.NewOrderSingle, sessionID
 		execReport.SetAccount(acct)
 	}
 
-	quickfix.SendToTarget(execReport, sessionID)
+	sendErr := quickfix.SendToTarget(execReport, sessionID)
+	if sendErr != nil {
+		fmt.Println(sendErr)
+	}
 
 	return
 }
@@ -309,7 +318,10 @@ func (e *executor) OnFIX43NewOrderSingle(msg fix43nos.NewOrderSingle, sessionID
 		execReport.SetAccount(acct)
 	}
 
-	quickfix.SendToTarget(execReport, sessionID)
+	sendErr := quickfix.SendToTarget(execReport, sessionID)
+	if sendErr != nil {
+		fmt.Println(sendErr)
+	}
 
 	return
 }
@@ -374,7 +386,10 @@ func (e *executor) OnFIX44NewOrderSingle(msg fix44nos.NewOrderSingle, sessionID
 		execReport.SetAccount(acct)
 	}
 
-	quickfix.SendToTarget(execReport, sessionID)
+	sendErr := quickfix.SendToTarget(execReport, sessionID)
+	if sendErr != nil {
+		fmt.Println(sendErr)
+	}
 
 	return
 }
@@ -439,7 +454,10 @@ func (e *executor) OnFIX50NewOrderSingle(msg fix50nos.NewOrderSingle, sessionID
 		execReport.SetAccount(acct)
 	}
 
-	quickfix.SendToTarget(execReport, sessionID)
+	sendErr := quickfix.SendToTarget(execReport, sessionID)
+	if sendErr != nil {
+		fmt.Println(sendErr)
+	}
 
 	return
 }
@@ -479,8 +497,8 @@ func main() {
 		return
 	}
 
-	interrupt := make(chan os.Signal)
-	signal.Notify(interrupt, os.Interrupt, os.Kill)
+	interrupt := make(chan os.Signal, 1)
+	signal.Notify(interrupt, os.Interrupt, syscall.SIGTERM)
 	<-interrupt
 
 	acceptor.Stop()

cmd/executor/main.go

@@ -8,6 +8,7 @@ import (
 	"os/signal"
 	"path"
 	"strconv"
+	"syscall"
 
 	"github.com/quickfixgo/enum"
 	"github.com/quickfixgo/examples/cmd/ordermatch/internal"
@@ -39,16 +40,16 @@ func newApplication() *Application {
 }
 
 //OnCreate implemented as part of Application interface
-func (a Application) OnCreate(sessionID quickfix.SessionID) { return }
+func (a Application) OnCreate(sessionID quickfix.SessionID) {}
 
 //OnLogon implemented as part of Application interface
-func (a Application) OnLogon(sessionID quickfix.SessionID) { return }
+func (a Application) OnLogon(sessionID quickfix.SessionID) {}
 
 //OnLogout implemented as part of Application interface
-func (a Application) OnLogout(sessionID quickfix.SessionID) { return }
+func (a Application) OnLogout(sessionID quickfix.SessionID) {}
 
 //ToAdmin implemented as part of Application interface
-func (a Application) ToAdmin(msg *quickfix.Message, sessionID quickfix.SessionID) { return }
+func (a Application) ToAdmin(msg *quickfix.Message, sessionID quickfix.SessionID) {}
 
 //ToApp implemented as part of Application interface
 func (a Application) ToApp(msg *quickfix.Message, sessionID quickfix.SessionID) error {
@@ -205,7 +206,11 @@ func (a *Application) updateOrder(order internal.Order, status enum.OrdStatus) {
 	execReport.Header.SetTargetCompID(order.SenderCompID)
 	execReport.Header.SetSenderCompID(order.TargetCompID)
 
-	quickfix.Send(execReport)
+	sendErr := quickfix.Send(execReport)
+	if sendErr != nil {
+		fmt.Println(sendErr)
+	}
+
 }
 
 func main() {
@@ -243,8 +248,8 @@ func main() {
 		return
 	}
 
-	interrupt := make(chan os.Signal)
-	signal.Notify(interrupt, os.Interrupt, os.Kill)
+	interrupt := make(chan os.Signal, 1)
+	signal.Notify(interrupt, os.Interrupt, syscall.SIGTERM)
 	go func() {
 		<-interrupt
 		acceptor.Stop()