Merge pull request #510 from sylr/remove-keepMessage

ackleymi · web-flow · commit 07872e7088f6 · 2023-05-07T22:37:52.000-05:00
Remove unsused Message.keepMessage
diff --git a/in_session.go b/in_session.go
@@ -290,8 +290,6 @@ func (state inSession) processReject(session *session, msg *Message, rej Message
 		}
 
 		nextState.messageStash[TypedError.ReceivedTarget] = msg
-		// Do not reclaim stashed message.
-		msg.keepMessage = true
 
 		return nextState
 
diff --git a/message.go b/message.go
@@ -104,9 +104,6 @@ type Message struct {
 
 	// Field bytes as they appear in the raw message.
 	fields []TagValue
-
-	// Flag is true if this message should not be returned to pool after use.
-	keepMessage bool
 }
 
 // ToMessage returns the message itself.

Original file line number	Diff line number	Diff line change
`@@ -290,8 +290,6 @@ func (state inSession) processReject(session session, msg Message, rej Message`
`290`	`290`	`}`
`291`	`291`
`292`	`292`	`nextState.messageStash[TypedError.ReceivedTarget] = msg`
`293`		`- // Do not reclaim stashed message.`
`294`		`- msg.keepMessage = true`
`295`	`293`
`296`	`294`	`return nextState`
`297`	`295`
Original file line number	Diff line number	Diff line change
`@@ -104,9 +104,6 @@ type Message struct {`
`104`	`104`
`105`	`105`	`// Field bytes as they appear in the raw message.`
`106`	`106`	`fields []TagValue`
`107`		`-`
`108`		`- // Flag is true if this message should not be returned to pool after use.`
`109`		`- keepMessage bool`
`110`	`107`	`}`
`111`	`108`
`112`	`109`	`// ToMessage returns the message itself.`