Merge pull request #534 from quickfixgo/fix-persist-seqnum

Satisfy linter reqs

Author: ackleymi

.github/workflows/ci.yaml

@@ -30,13 +30,11 @@ jobs:
       - name: Install golangci-lint
         run: |
           curl -sSLO https://github.com/golangci/golangci-lint/releases/download/v$GOLANGCI_LINT_VERSION/golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz
-          shasum -a 256 golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz | grep "^$GOLANGCI_LINT_SHA256  " > /dev/null
           tar -xf golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz
           sudo mv golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64/golangci-lint /usr/local/bin/golangci-lint
           rm -rf golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64*
         env:
-          GOLANGCI_LINT_VERSION: '1.46.2'
-          GOLANGCI_LINT_SHA256: '242cd4f2d6ac0556e315192e8555784d13da5d1874e51304711570769c4f2b9b'
+          GOLANGCI_LINT_VERSION: '1.50.1'
       - name: Run Lint
         run: make lint
 

Makefile

@@ -19,7 +19,7 @@ test:
 linters-install:
 	@golangci-lint --version >/dev/null 2>&1 || { \
 		echo "installing linting tools..."; \
-		curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s v1.46.2; \
+		curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s v1.50.1; \
 	}
 
 lint: linters-install

acceptor.go

@@ -15,7 +15,7 @@ import (
 	"github.com/quickfixgo/quickfix/config"
 )
 
-//Acceptor accepts connections from FIX clients and manages the associated sessions.
+// Acceptor accepts connections from FIX clients and manages the associated sessions.
 type Acceptor struct {
 	app                   Application
 	settings              *Settings
@@ -43,7 +43,7 @@ type ConnectionValidator interface {
 	Validate(netConn net.Conn, session SessionID) error
 }
 
-//Start accepting connections.
+// Start accepting connections.
 func (a *Acceptor) Start() (err error) {
 	socketAcceptHost := ""
 	if a.settings.GlobalSettings().HasSetting(config.SocketAcceptHost) {
@@ -112,7 +112,7 @@ func (a *Acceptor) Start() (err error) {
 	return
 }
 
-//Stop logs out existing sessions, close their connections, and stop accepting new connections.
+// Stop logs out existing sessions, close their connections, and stop accepting new connections.
 func (a *Acceptor) Stop() {
 	defer func() {
 		_ = recover() // suppress sending on closed channel error
@@ -141,7 +141,7 @@ func (a *Acceptor) RemoteAddr(sessionID SessionID) (net.Addr, bool) {
 	return val, ok
 }
 
-//NewAcceptor creates and initializes a new Acceptor.
+// NewAcceptor creates and initializes a new Acceptor.
 func NewAcceptor(app Application, storeFactory MessageStoreFactory, settings *Settings, logFactory LogFactory) (a *Acceptor, err error) {
 	a = &Acceptor{
 		app:             app,
@@ -394,7 +394,8 @@ LOOP:
 // Use it when you need a custom authentication logic that includes lower level interactions,
 // like mTLS auth or IP whitelistening.
 // To remove a previously set validator call it with a nil value:
-// 	a.SetConnectionValidator(nil)
+//
+//	a.SetConnectionValidator(nil)
 func (a *Acceptor) SetConnectionValidator(validator ConnectionValidator) {
 	a.connectionValidator = validator
 }

application.go

@@ -1,7 +1,7 @@
 package quickfix
 
-//Application interface should be implemented by FIX Applications.
-//This is the primary interface for processing messages from a FIX Session.
+// Application interface should be implemented by FIX Applications.
+// This is the primary interface for processing messages from a FIX Session.
 type Application interface {
 	//OnCreate notification of a session begin created.
 	OnCreate(sessionID SessionID)

begin_string.go

@@ -1,6 +1,6 @@
 package quickfix
 
-//FIX BeginString string values
+// FIX BeginString string values
 const (
 	BeginStringFIX40  = "FIX.4.0"
 	BeginStringFIX41  = "FIX.4.1"

config/configuration.go

@@ -2,7 +2,7 @@ package config
 
 //NOTE: Additions to this file should be made to both config/doc.go and http://www.quickfixgo.org/docs/
 
-//Const configuration settings
+// Const configuration settings
 const (
 	BeginString                  string = "BeginString"
 	SenderCompID                 string = "SenderCompID"