Skip to content

Commit a18c889

Browse files
committed
Revert and fix send message session registry
1 parent d16398a commit a18c889

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

fix_string_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ func TestFIXStringRead(t *testing.T) {
4444
expectError bool
4545
}{
4646
{[]byte("blah"), "blah", false},
47+
{nil, "", false},
48+
{[]byte(""), "", false},
4749
}
4850

4951
for _, test := range tests {

registry.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,10 @@ func Send(m Messagable) (err error) {
4545

4646
var senderCompID FIXString
4747
if err := msg.Header.GetField(tagSenderCompID, &senderCompID); err != nil {
48-
49-
return nil
48+
return err
5049
}
5150

52-
var targetSubID FIXString
53-
msg.Header.GetField(tagTargetSubID, &targetSubID)
54-
55-
sessionID := SessionID{BeginString: string(beginString), TargetCompID: string(targetCompID), SenderCompID: string(senderCompID), TargetSubID: string(targetSubID)}
51+
sessionID := SessionID{BeginString: string(beginString), TargetCompID: string(targetCompID), SenderCompID: string(senderCompID)}
5652

5753
return SendToTarget(msg, sessionID)
5854
}

0 commit comments

Comments
 (0)