Adding more context information to the errors

Author: rodolfo-seedcx

datadictionary/datadictionary.go

@@ -5,6 +5,8 @@ import (
 	"encoding/xml"
 	"io"
 	"os"
+
+	"github.com/pkg/errors"
 )
 
 //DataDictionary models FIX messages, components, and fields.
@@ -297,24 +299,25 @@ func NewMessageDef(name, msgType string, parts []MessagePart) *MessageDef {
 	return &msg
 }
 
-//Parse loads and and build a datadictionary instance from an xml file.
+//Parse loads and build a datadictionary instance from an xml file.
 func Parse(path string) (*DataDictionary, error) {
 	var xmlFile *os.File
-	xmlFile, err := os.Open(path)
+	var err error
+	xmlFile, err = os.Open(path)
 	if err != nil {
-		return nil, err
+		return nil, errors.Wrapf(err, "problem opening file: %v", path)
 	}
 	defer xmlFile.Close()
 
 	return ParseSrc(xmlFile)
 }
 
-//ParseSrc loads and and build a datadictionary instance from an xml source.
+//ParseSrc loads and build a datadictionary instance from an xml source.
 func ParseSrc(xmlSrc io.Reader) (*DataDictionary, error) {
 	doc := new(XMLDoc)
 	decoder := xml.NewDecoder(xmlSrc)
 	if err := decoder.Decode(doc); err != nil {
-		return nil, err
+		return nil, errors.Wrapf(err, "problem parsing XML file")
 	}
 
 	b := new(builder)

internal/time_range.go

@@ -1,8 +1,9 @@
 package internal
 
 import (
-	"errors"
 	"time"
+
+	"github.com/pkg/errors"
 )
 
 //TimeOfDay represents the time of day
@@ -13,8 +14,6 @@ type TimeOfDay struct {
 
 const shortForm = "15:04:05"
 
-var errParseTime = errors.New("Time must be in the format HH:MM:SS")
-
 //NewTimeOfDay returns a newly initialized TimeOfDay
 func NewTimeOfDay(hour, minute, second int) TimeOfDay {
 	d := time.Duration(second)*time.Second +
@@ -28,7 +27,7 @@ func NewTimeOfDay(hour, minute, second int) TimeOfDay {
 func ParseTimeOfDay(str string) (TimeOfDay, error) {
 	t, err := time.Parse(shortForm, str)
 	if err != nil {
-		return TimeOfDay{}, errParseTime
+		return TimeOfDay{}, errors.Wrap(err, "time must be in the format HH:MM:SS")
 	}
 
 	return NewTimeOfDay(t.Clock()), nil

session_factory.go

@@ -1,11 +1,12 @@
 package quickfix
 
 import (
-	"errors"
 	"net"
 	"strconv"
 	"time"
 
+	"github.com/pkg/errors"
+
 	"github.com/quickfixgo/quickfix/config"
 	"github.com/quickfixgo/quickfix/datadictionary"
 	"github.com/quickfixgo/quickfix/internal"
@@ -103,10 +104,18 @@ func (f sessionFactory) newSession(
 			}
 
 			if s.transportDataDictionary, err = datadictionary.Parse(transportDataDictionaryPath); err != nil {
+				err = errors.Wrapf(
+					err, "problem parsing XML datadictionary path '%v' for setting '%v",
+					settings.settings[config.TransportDataDictionary], config.TransportDataDictionary,
+				)
 				return
 			}
 
 			if s.appDataDictionary, err = datadictionary.Parse(appDataDictionaryPath); err != nil {
+				err = errors.Wrapf(
+					err, "problem parsing XML datadictionary path '%v' for setting '%v",
+					settings.settings[config.AppDataDictionary], config.AppDataDictionary,
+				)
 				return
 			}
 
@@ -119,6 +128,10 @@ func (f sessionFactory) newSession(
 		}
 
 		if s.appDataDictionary, err = datadictionary.Parse(dataDictionaryPath); err != nil {
+			err = errors.Wrapf(
+				err, "problem parsing XML datadictionary path '%v' for setting '%v",
+				settings.settings[config.DataDictionary], config.DataDictionary,
+			)
 			return
 		}
 
@@ -198,10 +211,18 @@ func (f sessionFactory) newSession(
 
 		var start, end internal.TimeOfDay
 		if start, err = internal.ParseTimeOfDay(startTimeStr); err != nil {
+			err = errors.Wrapf(
+				err, "problem parsing time of day '%v' for setting '%v",
+				settings.settings[config.StartTime], config.StartTime,
+			)
 			return
 		}
 
 		if end, err = internal.ParseTimeOfDay(endTimeStr); err != nil {
+			err = errors.Wrapf(
+				err, "problem parsing time of day '%v' for setting '%v",
+				settings.settings[config.EndTime], config.EndTime,
+			)
 			return
 		}
 
@@ -214,6 +235,10 @@ func (f sessionFactory) newSession(
 
 			loc, err = time.LoadLocation(locStr)
 			if err != nil {
+				err = errors.Wrapf(
+					err, "problem parsing time zone '%v' for setting '%v",
+					settings.settings[config.TimeZone], config.TimeZone,
+				)
 				return
 			}
 		}
@@ -404,7 +429,7 @@ func (f sessionFactory) buildHeartBtIntSettings(session *session, settings *Sess
 			return
 		}
 	}
-	
+
 	if session.HeartBtIntOverride || mustProvide {
 		var heartBtInt int
 		if heartBtInt, err = settings.IntSetting(config.HeartBtInt); err != nil {

session_settings.go

@@ -100,7 +100,7 @@ func (s *SessionSettings) DurationSetting(setting string) (val time.Duration, er
 	return
 }
 
-//BoolSetting returns the requested setting parsed as a boolean.  Returns an errror if the setting is not set or cannot be parsed as a bool.
+//BoolSetting returns the requested setting parsed as a boolean.  Returns an error if the setting is not set or cannot be parsed as a bool.
 func (s SessionSettings) BoolSetting(setting string) (bool, error) {
 	stringVal, err := s.Setting(setting)