Skip to content

Commit eb54430

Browse files
authored
Merge pull request #239 from teloon/fix-time-range
Fix time range
2 parents 3f0c754 + a46f7b3 commit eb54430

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

internal/time_range.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,10 @@ func (r *TimeRange) isInWeekRange(t time.Time) bool {
8989
return r.isInTimeRange(t)
9090
}
9191

92+
if r.startTime.d < r.endTime.d {
93+
return false
94+
}
95+
9296
return true
9397
}
9498

internal/time_range_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,20 @@ func TestTimeRangeIsInRangeWithDay(t *testing.T) {
204204

205205
now = time.Date(2006, time.December, 4, 9, 0, 0, 0, time.UTC)
206206
assert.True(t, NewUTCWeekRange(startTime, endTime, startDay, endDay).IsInRange(now))
207+
208+
startTime = NewTimeOfDay(8, 59, 0)
209+
endTime = NewTimeOfDay(9, 1, 0)
210+
startDay = time.Sunday
211+
endDay = time.Sunday
212+
213+
now = time.Date(2006, time.December, 3, 8, 59, 0, 0, time.UTC)
214+
assert.True(t, NewUTCWeekRange(startTime, endTime, startDay, endDay).IsInRange(now))
215+
216+
now = time.Date(2006, time.December, 3, 9, 1, 0, 0, time.UTC)
217+
assert.True(t, NewUTCWeekRange(startTime, endTime, startDay, endDay).IsInRange(now))
218+
219+
now = time.Date(2006, time.December, 4, 8, 59, 0, 0, time.UTC)
220+
assert.False(t, NewUTCWeekRange(startTime, endTime, startDay, endDay).IsInRange(now))
207221
}
208222

209223
func TestTimeRangeIsInSameRange(t *testing.T) {

0 commit comments

Comments
 (0)