Skip to content

Commit 291eb9c

Browse files
authored
Remove test_conv.c (#800)
We only build it, we never run it, and it's fairly slow to build. It's an almost verbatim copy of a sizable part of cutils.c that _is_ tested so let's just remove it. Fixes: #788
1 parent 4b8057d commit 291eb9c

File tree

3 files changed

+0
-1765
lines changed

3 files changed

+0
-1765
lines changed

CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -370,10 +370,6 @@ if(BUILD_EXAMPLES)
370370
target_link_libraries(test_fib qjs)
371371
endif()
372372

373-
add_executable(test_conv
374-
tests/test_conv.c
375-
)
376-
377373
# Install target
378374
#
379375

Makefile

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ $(QJS): $(BUILD_DIR)
5858
$(QJSC): $(BUILD_DIR)
5959
cmake --build $(BUILD_DIR) --target qjsc -j $(JOBS)
6060

61-
$(BUILD_DIR)/test_conv: $(BUILD_DIR) tests/test_conv.c
62-
cmake --build $(BUILD_DIR) --target test_conv
63-
6461
install: $(QJS) $(QJSC)
6562
cmake --build $(BUILD_DIR) --target install
6663

@@ -99,9 +96,6 @@ cxxtest: cxxtest.cc quickjs.h
9996
test: $(QJS)
10097
$(RUN262) -c tests.conf
10198

102-
testconv: $(BUILD_DIR)/test_conv
103-
$(BUILD_DIR)/test_conv
104-
10599
test262: $(QJS)
106100
$(RUN262) -m -c test262.conf -a
107101

0 commit comments

Comments
 (0)