Skip to content

Commit e9f4dbb

Browse files
committed
Disable msvc warnings in source files
...instead of from the cmake build file.
1 parent 3d3b58d commit e9f4dbb

File tree

2 files changed

+20
-17
lines changed

2 files changed

+20
-17
lines changed

CMakeLists.txt

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -64,23 +64,6 @@ if(MSVC)
6464
xcheck_add_c_compiler_flag(-Wno-reserved-identifier)
6565
xcheck_add_c_compiler_flag(-Wdeprecated-declarations)
6666
xcheck_add_c_compiler_flag(/experimental:c11atomics)
67-
xcheck_add_c_compiler_flag(/wd4018) # -Wno-sign-conversion
68-
xcheck_add_c_compiler_flag(/wd4061) # -Wno-implicit-fallthrough
69-
xcheck_add_c_compiler_flag(/wd4100) # -Wno-unused-parameter
70-
xcheck_add_c_compiler_flag(/wd4200) # -Wno-zero-length-array
71-
xcheck_add_c_compiler_flag(/wd4242) # -Wno-shorten-64-to-32
72-
xcheck_add_c_compiler_flag(/wd4244) # -Wno-shorten-64-to-32
73-
xcheck_add_c_compiler_flag(/wd4245) # -Wno-sign-compare
74-
xcheck_add_c_compiler_flag(/wd4267) # -Wno-shorten-64-to-32
75-
xcheck_add_c_compiler_flag(/wd4388) # -Wno-sign-compare
76-
xcheck_add_c_compiler_flag(/wd4389) # -Wno-sign-compare
77-
xcheck_add_c_compiler_flag(/wd4456) # Hides previous local declaration
78-
xcheck_add_c_compiler_flag(/wd4457) # Hides function parameter
79-
xcheck_add_c_compiler_flag(/wd4710) # Function not inlined
80-
xcheck_add_c_compiler_flag(/wd4711) # Function was inlined
81-
xcheck_add_c_compiler_flag(/wd4820) # Padding added after construct
82-
xcheck_add_c_compiler_flag(/wd4996) # -Wdeprecated-declarations
83-
xcheck_add_c_compiler_flag(/wd5045) # Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified
8467
endif()
8568

8669
# Set a 8MB default stack size on Windows.

quickjs.c

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,26 @@
4343
#include <fenv.h>
4444
#include <math.h>
4545

46+
#ifdef _MSC_VER
47+
#pragma warning(disable: 4018) // -Wno-sign-conversion
48+
#pragma warning(disable: 4061) // -Wno-implicit-fallthrough
49+
#pragma warning(disable: 4100) // -Wno-unused-parameter
50+
#pragma warning(disable: 4200) // -Wno-zero-length-array
51+
#pragma warning(disable: 4242) // -Wno-shorten-64-to-32
52+
#pragma warning(disable: 4244) // -Wno-shorten-64-to-32
53+
#pragma warning(disable: 4245) // -Wno-sign-compare
54+
#pragma warning(disable: 4267) // -Wno-shorten-64-to-32
55+
#pragma warning(disable: 4388) // -Wno-sign-compare
56+
#pragma warning(disable: 4389) // -Wno-sign-compare
57+
#pragma warning(disable: 4456) // Hides previous local declaration
58+
#pragma warning(disable: 4457) // Hides function parameter
59+
#pragma warning(disable: 4710) // Function not inlined
60+
#pragma warning(disable: 4711) // Function was inlined
61+
#pragma warning(disable: 4820) // Padding added after construct
62+
#pragma warning(disable: 4996) // -Wdeprecated-declarations
63+
#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified
64+
#endif
65+
4666
#include "cutils.h"
4767
#include "list.h"
4868
#include "quickjs.h"

0 commit comments

Comments
 (0)