Skip to content

Commit d25f9bb

Browse files
committed
fix: linting issues in src/dbus dir
1 parent f7dee7a commit d25f9bb

File tree

3 files changed

+60
-61
lines changed

3 files changed

+60
-61
lines changed

src/dbus/org.freedesktop.ScreenSaver.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
<node>
22
<interface name="org.freedesktop.ScreenSaver">
33
<!-- Get the current lock state -->
4-
<method name="GetActive">
4+
<method name="getActive">
55
<arg name="active" direction="out" type="b"/>
66
</method>
77

88
<!-- Signal emitted when lock state changes -->
9-
<signal name="ActiveChanged">
9+
<signal name="activeChanged">
1010
<arg name="active" type="b"/>
1111
</signal>
1212

1313
<!-- Get whether the compositor has confirmed the lock (secure state) -->
14-
<method name="GetSecure">
14+
<method name="getSecure">
1515
<arg name="secure" direction="out" type="b"/>
1616
</method>
1717
</interface>

src/dbus/screensaver_dbus.cpp

Lines changed: 40 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -3,57 +3,63 @@
33
#include <QDBusConnection>
44
#include <QDBusError>
55
#include <QLoggingCategory>
6+
#include <QtGlobal> // QtWarningMsg
7+
#include <QObject> // emit
68

79
#include "../core/logcat.hpp"
810

11+
namespace {
912
QS_LOGGING_CATEGORY(logDbusScreenSaver, "quickshell.dbus.screensaver", QtWarningMsg);
13+
}
1014

1115
namespace qs::dbus {
1216

13-
ScreenSaverAdaptor::ScreenSaverAdaptor(QObject* parent): QDBusAbstractAdaptor(parent) {
14-
// Register on session bus
15-
auto connection = QDBusConnection::sessionBus();
16-
17-
if (!connection.registerService("org.freedesktop.ScreenSaver")) {
18-
qCWarning(logDbusScreenSaver) << "Failed to register DBus service org.freedesktop.ScreenSaver:"
19-
<< connection.lastError().message();
20-
} else {
21-
qCInfo(logDbusScreenSaver) << "Registered DBus service org.freedesktop.ScreenSaver";
22-
}
23-
24-
if (!connection
25-
.registerObject("/org/freedesktop/ScreenSaver", parent, QDBusConnection::ExportAdaptors))
26-
{
27-
qCWarning(logDbusScreenSaver) << "Failed to register DBus object /org/freedesktop/ScreenSaver:"
28-
<< connection.lastError().message();
29-
} else {
30-
qCInfo(logDbusScreenSaver) << "Registered DBus object /org/freedesktop/ScreenSaver";
31-
}
17+
ScreenSaverAdaptor::ScreenSaverAdaptor(QObject* parent)
18+
: QDBusAbstractAdaptor(parent)
19+
{
20+
// Register on session bus
21+
auto connection = QDBusConnection::sessionBus();
22+
23+
if (!connection.registerService("org.freedesktop.ScreenSaver")) {
24+
qCWarning(logDbusScreenSaver) << "Failed to register DBus service org.freedesktop.ScreenSaver:"
25+
<< connection.lastError().message();
26+
} else {
27+
qCInfo(logDbusScreenSaver) << "Registered DBus service org.freedesktop.ScreenSaver";
28+
}
29+
30+
if (!connection.registerObject("/org/freedesktop/ScreenSaver", parent,
31+
QDBusConnection::ExportAdaptors))
32+
{
33+
qCWarning(logDbusScreenSaver) << "Failed to register DBus object /org/freedesktop/ScreenSaver:"
34+
<< connection.lastError().message();
35+
} else {
36+
qCInfo(logDbusScreenSaver) << "Registered DBus object /org/freedesktop/ScreenSaver";
37+
}
3238
}
3339

3440
void ScreenSaverAdaptor::setActive(bool active) {
35-
if (this->mActive != active) {
36-
this->mActive = active;
37-
qCDebug(logDbusScreenSaver) << "Lock state changed to:" << active;
38-
emit this->ActiveChanged(active);
39-
}
41+
if (this->mActive != active) {
42+
this->mActive = active;
43+
qCDebug(logDbusScreenSaver) << "Lock state changed to:" << active;
44+
emit activeChanged(active); // method name fixed
45+
}
4046
}
4147

4248
void ScreenSaverAdaptor::setSecure(bool secure) {
43-
if (this->mSecure != secure) {
44-
this->mSecure = secure;
45-
qCDebug(logDbusScreenSaver) << "Secure state changed to:" << secure;
46-
}
49+
if (this->mSecure != secure) {
50+
this->mSecure = secure;
51+
qCDebug(logDbusScreenSaver) << "Secure state changed to:" << secure;
52+
}
4753
}
4854

49-
bool ScreenSaverAdaptor::GetActive() const {
50-
qCDebug(logDbusScreenSaver) << "GetActive called, returning:" << this->mActive;
51-
return this->mActive;
55+
bool ScreenSaverAdaptor::getActive() const { // method name fixed
56+
qCDebug(logDbusScreenSaver) << "getActive called, returning:" << this->mActive;
57+
return this->mActive;
5258
}
5359

54-
bool ScreenSaverAdaptor::GetSecure() const {
55-
qCDebug(logDbusScreenSaver) << "GetSecure called, returning:" << this->mSecure;
56-
return this->mSecure;
60+
bool ScreenSaverAdaptor::getSecure() const { // method name fixed
61+
qCDebug(logDbusScreenSaver) << "getSecure called, returning:" << this->mSecure;
62+
return this->mSecure;
5763
}
5864

5965
} // namespace qs::dbus

src/dbus/screensaver_dbus.hpp

Lines changed: 17 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,33 @@
11
#pragma once
22

3-
#include <qdbusabstractadaptor.h>
4-
#include <qobject.h>
5-
#include <qtmetamacros.h>
3+
#include <QDBusAbstractAdaptor>
4+
#include <QObject>
5+
#include <QtGlobal> // QtWarningMsg
66

77
namespace qs::dbus {
88

9-
// DBus adaptor for exposing screen lock state to other applications
10-
// Implements org.freedesktop.ScreenSaver interface
119
class ScreenSaverAdaptor: public QDBusAbstractAdaptor {
12-
Q_OBJECT
13-
Q_CLASSINFO("D-Bus Interface", "org.freedesktop.ScreenSaver")
10+
Q_OBJECT
11+
Q_CLASSINFO("D-Bus Interface", "org.freedesktop.ScreenSaver")
1412

1513
public:
16-
explicit ScreenSaverAdaptor(QObject* parent);
17-
~ScreenSaverAdaptor() override = default;
18-
Q_DISABLE_COPY_MOVE(ScreenSaverAdaptor);
14+
explicit ScreenSaverAdaptor(QObject* parent);
15+
~ScreenSaverAdaptor() override = default;
16+
Q_DISABLE_COPY_MOVE(ScreenSaverAdaptor);
1917

20-
// Update the active state and emit signal if changed
21-
void setActive(bool active);
22-
// Update the secure state (compositor has confirmed lock)
23-
void setSecure(bool secure);
18+
void setActive(bool active);
19+
void setSecure(bool secure);
2420

25-
public slots: // NOLINT
26-
// DBus method: Get current lock state
27-
[[nodiscard]] bool GetActive() const;
28-
// DBus method: Get whether lock is secure (compositor confirmed)
29-
[[nodiscard]] bool GetSecure() const;
21+
public slots:
22+
[[nodiscard]] bool getActive() const;
23+
[[nodiscard]] bool getSecure() const;
3024

31-
signals: // NOLINT
32-
// DBus signal: Emitted when lock state changes
33-
void ActiveChanged(bool active);
25+
signals:
26+
void activeChanged(bool active);
3427

3528
private:
36-
bool mActive = false;
37-
bool mSecure = false;
29+
bool mActive = false;
30+
bool mSecure = false;
3831
};
3932

4033
} // namespace qs::dbus

0 commit comments

Comments
 (0)