clippy (#5512)

Author: PSeitz

quickwit/quickwit-actors/src/universe.rs

@@ -28,6 +28,7 @@ use crate::spawn_builder::{SpawnBuilder, SpawnContext};
 use crate::{Actor, ActorExitStatus, Command, Inbox, Mailbox, QueueCapacity};
 
 /// Universe serves as the top-level context in which Actor can be spawned.
+///
 /// It is *not* a singleton. A typical application will usually have only one universe hosting all
 /// of the actors but it is not a requirement.
 ///

quickwit/quickwit-cli/src/index.rs

@@ -1238,7 +1238,7 @@ struct Printer<'a> {
     pub stdout: &'a mut Stdout,
 }
 
-impl<'a> Printer<'a> {
+impl Printer<'_> {
     pub fn print_header(&mut self, header: &str) -> io::Result<()> {
         write!(&mut self.stdout, " {}", header.bright_blue())?;
         Ok(())

quickwit/quickwit-cli/src/tool.rs

@@ -841,7 +841,7 @@ struct Printer<'a> {
     pub stdout: &'a mut Stdout,
 }
 
-impl<'a> Printer<'a> {
+impl Printer<'_> {
     pub fn print_header(&mut self, header: &str) -> io::Result<()> {
         write!(&mut self.stdout, " {}", header.bright_blue())?;
         Ok(())

quickwit/quickwit-common/src/metrics.rs

@@ -236,7 +236,7 @@ pub struct GaugeGuard<'a> {
     delta: i64,
 }
 
-impl<'a> std::fmt::Debug for GaugeGuard<'a> {
+impl std::fmt::Debug for GaugeGuard<'_> {
     fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
         self.delta.fmt(f)
     }
@@ -262,7 +262,7 @@ impl<'a> GaugeGuard<'a> {
     }
 }
 
-impl<'a> Drop for GaugeGuard<'a> {
+impl Drop for GaugeGuard<'_> {
     fn drop(&mut self) {
         self.gauge.sub(self.delta)
     }

quickwit/quickwit-common/src/sorted_iter.rs

@@ -106,10 +106,10 @@ impl<T> SortedIterator for T where T: Iterator + Sorted {}
 
 impl<K, V> Sorted for btree_map::IntoKeys<K, V> {}
 impl<K, V> Sorted for btree_map::IntoValues<K, V> {}
-impl<'a, K, V> Sorted for btree_map::Keys<'a, K, V> {}
-impl<'a, K, V> Sorted for btree_map::Values<'a, K, V> {}
+impl<K, V> Sorted for btree_map::Keys<'_, K, V> {}
+impl<K, V> Sorted for btree_map::Values<'_, K, V> {}
 impl<K> Sorted for btree_set::IntoIter<K> {}
-impl<'a, K> Sorted for btree_set::Iter<'a, K> {}
+impl<K> Sorted for btree_set::Iter<'_, K> {}
 
 /// Same as [`SortedIterator`] but for (key, value) pairs sorted by key.
 pub trait SortedByKeyIterator<K, V>: Iterator + Sized {
@@ -194,7 +194,7 @@ where
 impl<T, K, V> SortedByKeyIterator<K, V> for T where T: Iterator<Item = (K, V)> + Sorted {}
 
 impl<K, V> Sorted for btree_map::IntoIter<K, V> {}
-impl<'a, K, V> Sorted for btree_map::Iter<'a, K, V> {}
+impl<K, V> Sorted for btree_map::Iter<'_, K, V> {}
 
 #[cfg(test)]
 mod tests {

quickwit/quickwit-common/src/temp_dir.rs

@@ -82,7 +82,7 @@ pub struct Builder<'a> {
     num_rand_chars: usize,
 }
 
-impl<'a> Default for Builder<'a> {
+impl Default for Builder<'_> {
     fn default() -> Self {
         Self {
             parts: Default::default(),

quickwit/quickwit-control-plane/src/indexing_scheduler/mod.rs

@@ -403,7 +403,7 @@ struct IndexingPlansDiff<'a> {
     pub unplanned_tasks_by_node_id: FnvHashMap<&'a str, Vec<&'a IndexingTask>>,
 }
 
-impl<'a> IndexingPlansDiff<'a> {
+impl IndexingPlansDiff<'_> {
     pub fn has_same_nodes(&self) -> bool {
         self.missing_node_ids.is_empty() && self.unplanned_node_ids.is_empty()
     }
@@ -454,7 +454,7 @@ fn get_shard_locality_metrics(
     }
 }
 
-impl<'a> fmt::Debug for IndexingPlansDiff<'a> {
+impl fmt::Debug for IndexingPlansDiff<'_> {
     fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {
         if self.has_same_nodes() && self.has_same_tasks() {
             return write!(formatter, "EmptyIndexingPlansDiff");

quickwit/quickwit-directories/src/bundle_directory.rs

@@ -49,6 +49,7 @@ impl Debug for BundleDirectory {
 }
 
 /// Loads the split footer from a storage and path.
+///
 /// Returns (SplitFooter, BundleFooter)
 /// SplitFooter [BundleMetadata, BundleMetadata Len, Hotcache, Hotcache len]
 /// BundleFooter [BundleMetadata, BundleMetadata Len]

quickwit/quickwit-doc-mapper/src/query_builder.rs

@@ -146,7 +146,7 @@ impl<'a> ExtractTermSetFields<'a> {
     }
 }
 
-impl<'a, 'b> QueryAstVisitor<'a> for ExtractTermSetFields<'b> {
+impl<'a> QueryAstVisitor<'a> for ExtractTermSetFields<'_> {
     type Err = anyhow::Error;
 
     fn visit_term_set(&mut self, term_set_query: &'a TermSetQuery) -> anyhow::Result<()> {

quickwit/quickwit-indexing/src/actors/uploader.rs

@@ -68,6 +68,7 @@ pub enum UploaderType {
 }
 
 /// [`SplitsUpdateMailbox`] wraps either a [`Mailbox<Sequencer>`] or [`Mailbox<Publisher>`].
+///
 /// It makes it possible to send a [`SplitsUpdate`] either to the [`Sequencer`] or directly
 /// to [`Publisher`]. It is used in combination with `SplitsUpdateSender` that will do the send.
 ///