Skip to content

Commit 5d9c082

Browse files
authored
Fixing the coverage CI. (#1102)
This is a tricky problem. In the current setting, localstack should be accessed via localhost, not localstack. This is because right now the CI tests are running on a host, not in a dockerized environment. (The services are running in containers) I am not entirely sure how this is used to work.
1 parent 010e06e commit 5d9c082

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/coverage.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ on:
1212
- "quickwit-*/**"
1313

1414
env:
15-
QW_S3_ENDPOINT: "http://localstack:4566"
15+
QW_S3_ENDPOINT: "http://localhost:4566" # Services are exposed as localhost because we are not running coverage in a container.
1616
AWS_DEFAULT_REGION : "localhost"
1717
AWS_ACCESS_KEY_ID : "placeholder"
1818
AWS_SECRET_ACCESS_KEY: "placeholder"
@@ -22,6 +22,8 @@ jobs:
2222
test:
2323
name: coverage
2424
runs-on: ubuntu-latest
25+
# Setting a containing will require to fix the QW_S3_ENDPOINT to http://localstack:4566
26+
# container: ---
2527
services:
2628
localstack:
2729
image: localstack/localstack:latest

0 commit comments

Comments
 (0)