fix(52): fix readme (#59)

* feat: add content type detection for S3 file uploads

* fix: add metadata setup for events channel in state machine

* refactor: move readme template handling to PackagingStateMachine

* refactor: update readme template to use dynamic file placeholders

* refactor: separate readme creation into dedicated step function

* refactor: remove redundant createReadme step in state machine

* feat: add setupREADME step to initialize files context

* refactor: use this.props instead of passing props as method arguments

* fix props

* refactor: break down state machine definition into smaller methods

* readme.readme

* merge README task

* feat: add string processor lambda to state machine props

* refactor: move Lambda functions into PackagingStateMachine class

* test: add missing stringProcessor property to state machine tests

* refactor: remove lambda function props from webhook state machine

* fix: add missing PackagingStateMachine import and remove exportProcessor

* refactor: remove unused export processor function from test setup

* refactor: remove Lambda function from state machine props

* remove obsolete getContentType

* Create process-string.ts

* Webhook creates Packaging state machine

* refactor: use string processor Lambda for writing README to S3

* refactor: move writeReadmeToS3Task after createReadme step

* fix: update readme template to use correct files path

* Packaging vs PackageEntry

* smarter readme

* createReadmeTask

* feat: add entry markdown template constant

* refactor: convert entry template to AWS States Language format

* refactor: convert readme template to TypeScript class

* refactor: convert entry template to class-based implementation

* refactor: update entry template to use States.Format with proper placeholders

* refactor: create base template class for markdown generation

* fix: update template method names to use standardized base class methods

* refactor: restructure state machine content creation with named parameters

* cleanup

* fix: replace string concatenation with States.Format in state machine

* feat: add ENTRY_MD constant and use in state machine

* refactor: simplify entry template by removing complex fields

* test one template first

* Update readme.ts

* Update Package

---------

Co-authored-by: Dr. Ernie Prabhakar (aider) <19791+drernie@users.noreply.github.com>

Author: drernie

lib/benchling-webhook-stack.ts

@@ -23,7 +23,6 @@ export class BenchlingWebhookStack extends cdk.Stack {
     private readonly bucket: s3.IBucket;
     private readonly stateMachine: WebhookStateMachine;
     private readonly api: WebhookApi;
-    private readonly exportProcessor: lambda.IFunction;
 
     constructor(
         scope: Construct,
@@ -37,37 +36,9 @@ export class BenchlingWebhookStack extends cdk.Stack {
 
         this.bucket = s3.Bucket.fromBucketName(this, "BWBucket", props.bucketName);
 
-        // Create the export processor Lambda
-        this.exportProcessor = new nodejs.NodejsFunction(this, "ExportProcessor", {
-            entry: path.join(__dirname, "lambda/process-export.ts"),
-            handler: "handler",
-            runtime: lambda.Runtime.NODEJS_18_X,
-            timeout: cdk.Duration.minutes(5),
-            memorySize: 1024,
-            environment: {
-                NODE_OPTIONS: "--enable-source-maps",
-                QUILT_CATALOG: props.quiltCatalog || "open.quiltdata.com",
-            },
-            architecture: lambda.Architecture.ARM_64,
-            bundling: {
-                minify: true,
-                sourceMap: false,
-                externalModules: [
-                    "@aws-sdk/client-s3",
-                ],
-                forceDockerBundling: false,
-                target: "node18",
-                define: {
-                    "process.env.NODE_ENV": JSON.stringify(process.env.NODE_ENV || "production"),
-                },
-            },
-        });
-
-        // Grant the Lambda function access to the S3 bucket
-        this.bucket.grantReadWrite(this.exportProcessor);
-
         const benchlingConnection = this.createBenchlingConnection(props);
 
+        // Create the webhook state machine
         this.stateMachine = new WebhookStateMachine(this, "StateMachine", {
             bucket: this.bucket,
             prefix: props.prefix,
@@ -76,7 +47,6 @@ export class BenchlingWebhookStack extends cdk.Stack {
             account: this.account,
             benchlingConnection,
             benchlingTenant: props.benchlingTenant,
-            exportProcessor: this.exportProcessor,
             quiltCatalog: props.quiltCatalog,
         });
 

lib/constants.ts

@@ -8,6 +8,7 @@ export const FILES = {
     ENTRY_JSON: "entry.json",
     INPUT_JSON: "input.json",
     README_MD: "README.md",
+    ENTRY_MD: "entry.md",
 } as const;
 
 export const MIME_TYPES = {

lib/lambda/process-export.ts

@@ -30,7 +30,6 @@ export const handler = async (event: ProcessExportEvent): Promise<ProcessExportR
                     Bucket: event.registry,
                     Key: key,
                     Body: fileContent,
-                    ContentType: getContentType(entry.entryName),
                 }));
             }
         });
@@ -57,11 +56,3 @@ async function downloadFile(url: string): Promise<Buffer> {
     }
     return Buffer.from(await response.arrayBuffer());
 }
-
-import { MIME_TYPES } from "../constants";
-
-function getContentType(fileName: string): string {
-    const extension = fileName.split(".").pop()?.toLowerCase() || "";
-    const mimeTypeKey = extension.toUpperCase() as keyof typeof MIME_TYPES;
-    return MIME_TYPES[mimeTypeKey] || MIME_TYPES.DEFAULT;
-}

lib/lambda/process-string.ts

@@ -0,0 +1,21 @@
+import { S3Client, PutObjectCommand } from "@aws-sdk/client-s3";
+
+const s3Client = new S3Client({});
+
+export interface ProcessStringEvent {
+    bucket: string;
+    key: string;
+    body: string;
+}
+
+export async function handler(event: ProcessStringEvent): Promise<void> {
+    const { bucket, key, body } = event;
+
+    await s3Client.send(
+        new PutObjectCommand({
+            Bucket: bucket,
+            Key: key,
+            Body: body,
+        })
+    );
+}