ui.actions.deleteObject for quilt config editor (#4692)

Author: fiskus

catalog/CHANGELOG.md

@@ -18,6 +18,7 @@ where verb is one of
 
 ## Changes
 
+- [Fixed] Add missing `deleteObject` property to GUI config editor to enable/disable delete buttons for files and directories ([#4692](https://github.com/quiltdata/quilt/pull/4692))
 - [Changed] Hide file and directory delete buttons in Bucket tab by default; enable with `ui.actions.deleteObject` ([#4689](https://github.com/quiltdata/quilt/pull/4689))
 - [Added] Display detailed permission error messages when bucket add/update fails due to insufficient S3 permissions ([#4670](https://github.com/quiltdata/quilt/pull/4670))
 - [Added] Support `prefixes` field in bucket configuration for prefix-scoped bucket access ([#4670](https://github.com/quiltdata/quilt/pull/4670))

catalog/app/components/FileEditor/QuiltConfigEditor/BucketPreferences/BucketPreferences.tsx

@@ -170,6 +170,8 @@ const I18N_FIELDS = {
   'ui.actions.copyPackage': '"PUSH TO BUCKET" on the package page',
   'ui.actions.createPackage':
     '"CREATE PACKAGE" on the package list and bucket listing pages',
+  'ui.actions.deleteObject':
+    'Buttons to delete files and directories under the "BUCKET" tab',
   'ui.actions.deleteRevision': '"DELETE REVISION" menu item on the package page',
   'ui.actions.downloadObject': 'Download buttons under the "BUCKET" tab',
   'ui.actions.downloadPackage': 'Download buttons under the "PACKAGES" tab',

catalog/app/components/FileEditor/QuiltConfigEditor/BucketPreferences/State.spec.ts

@@ -121,6 +121,7 @@ describe('components/FileEditor/QuiltConfigEditor/BucketPreferences/State', () =
   actions:
     copyPackage: false
     createPackage: false
+    deleteObject: false
     deleteRevision: true
     downloadObject: false
     downloadPackage: false
@@ -230,6 +231,7 @@ describe('components/FileEditor/QuiltConfigEditor/BucketPreferences/State', () =
   actions:
     copyPackage: false
     createPackage: false
+    deleteObject: false
     deleteRevision: true
     downloadObject: false
     downloadPackage: false
@@ -284,6 +286,7 @@ describe('components/FileEditor/QuiltConfigEditor/BucketPreferences/State', () =
       ).toStrictEqual({
         'ui.actions.copyPackage': false,
         'ui.actions.createPackage': false,
+        'ui.actions.deleteObject': false,
         'ui.actions.deleteRevision': true,
         'ui.actions.downloadObject': false,
         'ui.actions.downloadPackage': false,

catalog/app/components/FileEditor/QuiltConfigEditor/BucketPreferences/State.tsx

@@ -16,7 +16,10 @@ export interface TypedValue<V extends KeyedValue['value']> {
 
 export type KeyedValue<K extends Key = Key> = TypedValue<NonNullable<Defaults[K]>>
 
-function childOfBool<T>(parent: undefined | boolean | Record<string, T>, key: string) {
+function childOfBool<T, K extends string>(
+  parent: undefined | boolean | Partial<Record<K, T>>,
+  key: K,
+) {
   return typeof parent === 'boolean' ? parent : parent?.[key]
 }
 
@@ -33,6 +36,7 @@ function parseUser(config: string) {
   return {
     'ui.actions.copyPackage': childOfBool(json?.ui?.actions, 'copyPackage'),
     'ui.actions.createPackage': childOfBool(json?.ui?.actions, 'createPackage'),
+    'ui.actions.deleteObject': childOfBool(json?.ui?.actions, 'deleteObject'),
     'ui.actions.deleteRevision': childOfBool(json?.ui?.actions, 'deleteRevision'),
     'ui.actions.downloadObject': childOfBool(json?.ui?.actions, 'downloadObject'),
     'ui.actions.downloadPackage': childOfBool(json?.ui?.actions, 'downloadPackage'),
@@ -78,6 +82,7 @@ type Defaults = Required<ReturnType<typeof parseUser>>
 const sys: Defaults = {
   'ui.actions.copyPackage': true,
   'ui.actions.createPackage': true,
+  'ui.actions.deleteObject': false,
   'ui.actions.deleteRevision': false,
   'ui.actions.downloadObject': true,
   'ui.actions.downloadPackage': true,
@@ -137,6 +142,7 @@ export function parse(config: string, ext: Partial<Defaults>) {
   return {
     'ui.actions.copyPackage': val('ui.actions.copyPackage', user, ext),
     'ui.actions.createPackage': val('ui.actions.createPackage', user, ext),
+    'ui.actions.deleteObject': val('ui.actions.deleteObject', user, ext),
     'ui.actions.deleteRevision': val('ui.actions.deleteRevision', user, ext),
     'ui.actions.downloadObject': val('ui.actions.downloadObject', user, ext),
     'ui.actions.downloadPackage': val('ui.actions.downloadPackage', user, ext),

catalog/app/components/FileEditor/QuiltConfigEditor/BucketPreferences/__snapshots__/BucketPreferences.spec.tsx.snap

@@ -69,6 +69,24 @@ exports[`components/FileEditor/QuiltConfigEditor/BucketPreferences/BucketPrefere
           </span>
         </label>
       </div>
+      <div
+        class="MuiFormControl-root"
+      >
+        <label
+          class="MuiFormControlLabel-root"
+        >
+          <div
+            id="checkbox"
+          >
+            false
+          </div>
+          <span
+            class="MuiTypography-root MuiFormControlLabel-label MuiTypography-body1"
+          >
+            Buttons to delete files and directories under the "BUCKET" tab
+          </span>
+        </label>
+      </div>
       <div
         class="MuiFormControl-root"
       >
@@ -768,6 +786,24 @@ exports[`components/FileEditor/QuiltConfigEditor/BucketPreferences/BucketPrefere
           </span>
         </label>
       </div>
+      <div
+        class="MuiFormControl-root"
+      >
+        <label
+          class="MuiFormControlLabel-root"
+        >
+          <div
+            id="checkbox"
+          >
+            false
+          </div>
+          <span
+            class="MuiTypography-root MuiFormControlLabel-label MuiTypography-body1"
+          >
+            Buttons to delete files and directories under the "BUCKET" tab
+          </span>
+        </label>
+      </div>
       <div
         class="MuiFormControl-root"
       >

catalog/app/utils/BucketPreferences/BucketPreferences.ts

@@ -144,6 +144,9 @@ const defaultGallery: GalleryPreferences = {
 }
 
 function getDefaultPreferences(bucket?: string): BucketPreferences {
+  // NOTE: if you add values here,
+  //       also update UI values for editor
+  //       in app/components/FileEditor/QuiltConfigEditor/BucketPreferences/State.tsx
   return {
     ui: {
       actions: {